[U-Boot] [PATCH 1/5] pmic: pmic_mc34vr500: Add a driver for the mc34vr500 pmic

[Z.Q. Hou]

Hi Jaehoon,

Thanks a lot for your review!

> -----Original Message-----
> From: Jaehoon Chung [mailto:jh80.chung at samsung.com]
> Sent: 2017年1月5日 9:46
> To: york sun <york.sun at nxp.com>; Z.Q. Hou <zhiqiang.hou at nxp.com>
> Cc: u-boot at lists.denx.de; sjg at chromium.org; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>; Shengzhou Liu <shengzhou.liu at nxp.com>;
> Priyanka Jain <priyanka.jain at nxp.com>; Mingkai Hu <mingkai.hu at nxp.com>
> Subject: Re: [PATCH 1/5] pmic: pmic_mc34vr500: Add a driver for the
> mc34vr500 pmic
> 
> Hi,
> 
> On 01/05/2017 05:33 AM, york sun wrote:
> > +Jaehoon to comment on the driver
> >
> > On 12/09/2016 12:22 AM, Zhiqiang Hou wrote:
> >> From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> >>
> >> This patch adds a simple pmic driver for the mc34vr500 pmic which is
> >> used in conjunction with the fsl T1 and LS1 series SoC.
> >>
> >> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> >> ---
> >>  drivers/power/pmic/Kconfig          |   7 ++
> >>  drivers/power/pmic/Makefile         |   1 +
> >>  drivers/power/pmic/pmic_mc34vr500.c |  32 +++++++
> >>  include/power/mc34vr500_pmic.h      | 166
> ++++++++++++++++++++++++++++++++++++
> >>  4 files changed, 206 insertions(+)
> >>  create mode 100644 drivers/power/pmic/pmic_mc34vr500.c
> >>  create mode 100644 include/power/mc34vr500_pmic.h
> >>
> 
> [snip]
> 
> >> +int power_mc34vr500_init(unsigned char bus); #endif /*
> >> +__MC34VR500_PMIC_H_ */
> >>
> >
> > Zhiqiang,
> >
> > I'd like to hear from Jaehoon before taking an action.
> 
> I hope that this driver will change to Driver model.

Yes, totally agree, but the DM PMIC framework depends on DM I2C. Once the Layerscape I2C DM driver is ready, I will send out the DM based MC34VR500 driver.

> Otherwise, there is no objection.
> 
> For PATCH[1/5]~[2/5],
> 
> Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>
> 

Thanks,
Zhiqiang