[U-Boot] [PATCH v2 1/2] lib: net_utils: make string_to_ip stricter

Chris Packham judge.packham at gmail.com
Thu Jan 5 08:58:43 CET 2017


Hi Wolfgang,

On Wed, Jan 4, 2017 at 11:04 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Chris,
>
> In message <20170104003626.4211-1-judge.packham at gmail.com> you wrote:
>>
>> With the input "1234192.168.1.1" the old behaviour would truncate the
>> address to 192.168.1.1. New behaviour rejects the string outright and
>> returns 0.0.0.0, which for the purposes of IP addresses can be
>> considered an error.
>
> Does code that calls string_to_ip() check for such an error
> condition?
>

It does by virtue of the fact that it will consider the global
variables for the various ip addresses unset and complain.


More information about the U-Boot mailing list