[U-Boot] [RFC Patch] drivers: mmc: omap_hsmmc: Fix IO Buffer on OMAP36XX

Tom Rini trini at konsulko.com
Wed Jan 11 00:14:17 CET 2017


On Mon, Jan 09, 2017 at 12:12:09PM -0600, aford173 at gmail.com wrote:

> From: Adam Ford <aford173 at gmail.com>
> 
> On the OMAP36xx (and 37xx) the CONTROL_WKUP_CTRL register has
> a field (bit 6) named GPIO_IO_PWRDNZ.  If 0, the IO buffers which
> are related to the MMC are disabled. After the PBIAS is configured,
> this bit should be set high to enable the MMC port.
> 
> Signed-off-by: Adam Ford <aford173 at gmail.com>
> 
> diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
> index 0a1ee40..069fd5a 100644
> --- a/drivers/mmc/omap_hsmmc.c
> +++ b/drivers/mmc/omap_hsmmc.c
> @@ -38,6 +38,7 @@
>  #include <asm/arch/sys_proto.h>
>  #endif
>  #include <dm.h>
> +#include <asm/arch-omap3/mux.h>
>  
>  DECLARE_GLOBAL_DATA_PTR;
>  
> @@ -115,6 +116,11 @@ static unsigned char mmc_board_init(struct mmc *mmc)
>  		PBIASSPEEDCTRL0 | PBIASLITEPWRDNZ0,
>  		&t2_base->pbias_lite);
>  
> +	if (get_cpu_family() == CPU_OMAP36XX)
> +		writel(readl(OMAP34XX_CTRL_WKUP_CTRL) |
> +				OMAP34XX_CTRL_WKUP_CTRL_GPIO_IO_PWRDNZ,
> +				OMAP34XX_CTRL_WKUP_CTRL);
> +
>  	writel(readl(&t2_base->devconf0) | MMCSDIO1ADPCLKISEL,
>  		&t2_base->devconf0);

I think I'd like to see this with a build-time check to avoid bloating
all of the other families.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170110/d970727a/attachment.sig>


More information about the U-Boot mailing list