[U-Boot] [PATCH v7 00/11] rockchip: Add gmac Ethernet support

[Simon Glass]

Hi Sjoerd,

On 12 January 2017 at 00:53, Sjoerd Simons
<sjoerd.simons at collabora.co.uk> wrote:
> On Wed, 2017-01-11 at 22:08 -0700, Simon Glass wrote:
>> Hi,
>>
>> On 11 January 2017 at 03:46, Romain Perier <romain.perier at collabora.c
>> om> wrote:
>> > > From Romain:
>> >
>> > This is a resent of Simon's v4 series. I have changed what was
>> > suggested
>> > by David Wu about the driver name (rename gmac_rk3288 to
>> > gmac_rockchip).
>> > I have also tested the whole series on a rock2 square board,
>> > updated the
>> > configuration files for rock2 board. I have fixed a build failure
>> > caused
>> > by recent changes in config_distro_defaults (CMD_PXE is no longer
>> > enabled,
>> > so I enabled DISTRO_DEFAULTS for Rockchip platforms by default). I
>> > have also
>> > added few Signed-off-by tags.
>>
>> I have tested this on a gigabit link and it does not work. I wonder
>> if
>> the clocks are wrong?
>>
>> However it works fine on 100Mbps which is better than what we have,
>> so
>> I'm going to apply this. Thank you for your work, Romain.
>
> Funny, my initial patchset only worked on gigabit due to a wrong phy
> clock on 100mbit/s. Hopefully should be an easy fix in a follow-up
> patch. Thanks for merging!

Yes, it worked OK for me ages ago when I first tested it, but I did
have a different setup. It gives a lot of timeouts for me now. As you
say it shouldn't be hard to resolve.

Regards,
Simon