[U-Boot] [PATCH v2 1/4] sunxi: add basic V3s support

[Maxime Ripard]

On Thu, Jan 12, 2017 at 03:38:59AM +0800, Icenowy Zheng wrote:
> >>   /*
> >>    * Miscellaneous configurable options
> >>  @@ -280,7 +290,11 @@ extern int soft_i2c_gpio_scl;
> >>    * The amount of RAM to keep free at the top of RAM when relocating u-boot,
> >>    * to use as framebuffer. This must be a multiple of 4096.
> >>    */
> >>  +#ifndef CONFIG_MACH_SUN8I_V3S
> >>   #define CONFIG_SUNXI_MAX_FB_SIZE (16 << 20)
> >>  +#else
> >>  +#define CONFIG_SUNXI_MAX_FB_SIZE (2 << 20)
> >>  +#endif
> >
> > Do you need that? CONFIG_VIDEO is disabled, so there's no need to
> > reserve space for a framebuffer.
> 
> I have task to implement VIDEO support. (V3s come with some LCD
> support)

Great ! :)

But then, that will only be useful when you'll have that support, so
it should be part of your serie then. For now it's just dead code.

> 
> >
> >>   /* Do we want to initialize a simple FB? */
> >>   #define CONFIG_VIDEO_DT_SIMPLEFB
> >>  @@ -383,27 +397,49 @@ extern int soft_i2c_gpio_scl;
> >>    * 32M uncompressed kernel, 16M compressed kernel, 1M fdt,
> >>    * 1M script, 1M pxe and the ramdisk at the end.
> >>    */
> >>  -
> >>  +#ifndef CONFIG_MACH_SUN8I_V3S
> >>  +#define BOOTM_SIZE __stringify(0xa000000)
> >>   #define KERNEL_ADDR_R __stringify(SDRAM_OFFSET(2000000))
> >>   #define FDT_ADDR_R __stringify(SDRAM_OFFSET(3000000))
> >>   #define SCRIPT_ADDR_R __stringify(SDRAM_OFFSET(3100000))
> >>   #define PXEFILE_ADDR_R __stringify(SDRAM_OFFSET(3200000))
> >>   #define RAMDISK_ADDR_R __stringify(SDRAM_OFFSET(3300000))
> >>  +#else
> >>  +/*
> >>  + * 64M RAM minus 2MB heap + 16MB for u-boot, stack, fb, etc.
> >>  + * 16M uncompressed kernel, 8M compressed kernel, 1M fdt,
> >>  + * 1M script, 1M pxe and the ramdisk at the end.
> >>  + */
> >>  +#define BOOTM_SIZE __stringify(0x2e00000)
> >>  +#define KERNEL_ADDR_R __stringify(SDRAM_OFFSET(1000000))
> >>  +#define FDT_ADDR_R __stringify(SDRAM_OFFSET(1800000))
> >>  +#define SCRIPT_ADDR_R __stringify(SDRAM_OFFSET(1900000))
> >>  +#define PXEFILE_ADDR_R __stringify(SDRAM_OFFSET(1A00000))
> >>  +#define RAMDISK_ADDR_R __stringify(SDRAM_OFFSET(1B00000))
> >>  +#endif
> >>   #endif
> >>
> >>   #define MEM_LAYOUT_ENV_SETTINGS \
> >>  - "bootm_size=0xa000000\0" \
> >>  + "bootm_size=" BOOTM_SIZE "\0" \
> >>           "kernel_addr_r=" KERNEL_ADDR_R "\0" \
> >>           "fdt_addr_r=" FDT_ADDR_R "\0" \
> >>           "scriptaddr=" SCRIPT_ADDR_R "\0" \
> >>           "pxefile_addr_r=" PXEFILE_ADDR_R "\0" \
> >>           "ramdisk_addr_r=" RAMDISK_ADDR_R "\0"
> >>
> >>  +#ifndef CONFIG_MACH_SUN8I_V3S
> >>   #define DFU_ALT_INFO_RAM \
> >>           "dfu_alt_info_ram=" \
> >>           "kernel ram " KERNEL_ADDR_R " 0x1000000;" \
> >>           "fdt ram " FDT_ADDR_R " 0x100000;" \
> >>           "ramdisk ram " RAMDISK_ADDR_R " 0x4000000\0"
> >>  +#else
> >>  +#define DFU_ALT_INFO_RAM \
> >>  + "dfu_alt_info_ram=" \
> >>  + "kernel ram " KERNEL_ADDR_R " 0x800000;" \
> >>  + "fdt ram " FDT_ADDR_R " 0x100000;" \
> >>  + "ramdisk ram " RAMDISK_ADDR_R " 0x1000000\0"
> >>  +#endif
> >
> > Do you even support DFU?
> 
> Also in task.

Then same thing.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170112/6d99a869/attachment.sig>