[U-Boot] [PATCH v2] cmd/fdt: Make fdt get value endian-safe for single-cell properties

Simon Glass sjg at chromium.org
Sat Jan 14 18:14:36 CET 2017


On 12 January 2017 at 19:19, Simon Glass <sjg at chromium.org> wrote:
> On 9 January 2017 at 08:08, Andreas Färber <afaerber at suse.de> wrote:
>> On a Raspberry Pi 2 disagreements on cell endianness can be observed:
>>
>>   U-Boot> fdt print /soc/gpio at 7e200000 phandle
>>   phandle = <0x0000000d>
>>   U-Boot> fdt get value myvar /soc/gpio at 7e200000 phandle; printenv myvar
>>   myvar=0x0D000000
>>
>> Fix this by always treating the pointer as BE and converting it in
>> fdt_value_setenv(), like its counterpart fdt_parse_prop() already does.
>>
>> Consistently use fdt32_t, fdt32_to_cpu() and cpu_to_fdt32().
>>
>> Fixes: bc80295 ("fdt: Add get commands to fdt")
>> Cc: Joe Hershberger <joe.hershberger at ni.com>
>> Cc: Gerald Van Baren <gvb at unssw.com>
>> Signed-off-by: Andreas Färber <afaerber at suse.de>
>> ---
>>  cmd/fdt.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Simon Glass <sjg at chromium.org>

Applied to u-boot-fdt, thanks!


More information about the U-Boot mailing list