[U-Boot] cmd: sata: fix init command return value

Tom Rini trini at konsulko.com
Sun Jan 15 19:32:35 CET 2017


On Wed, Jan 11, 2017 at 04:51:53PM +0100, Gary Bisson wrote:

> Since commit aa6ab905b2, sata_initialize returns -1 if init_sata or
> scan_sata fails. But this return value becomes the do_sata return
> value which is equivalent to CMD_RET_USAGE.
> 
> In case one issues 'sata init' and that the hardware fails to
> initialize, there's no need to display the command usage. Instead
> the command shoud just return the CMD_RET_FAILURE value.
> 
> Fixes: aa6ab905b2 (sata: fix sata command can not being executed bug)
> 
> Signed-off-by: Gary Bisson <gary.bisson at boundarydevices.com>
> Reviewed-by: Eric Nelson <eric at nelint.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170115/b4340c86/attachment.sig>


More information about the U-Boot mailing list