[U-Boot] [PATCH RESEND v2] at91: video: Support driver-model for the HLCD driver

[Wu, Songjun]

Hi Anatolij,

Thank you very much for you comments.
I will make a new patch to fix these issues.

On 1/14/2017 03:17, Anatolij Gustschin wrote:
> Hi,
>
> On Wed, 11 Jan 2017 10:36:48 +0800
> Songjun Wu songjun.wu at microchip.com wrote:
>
>> Add driver-model support to this driver.
>>
>> Signed-off-by: Songjun Wu <songjun.wu at microchip.com>
>> ---
>>
>> Changes in v2:
>> - Due to the peripheral clock driver improvement, remove
>>   the unneccessary clock calling.
>>
>>  drivers/video/Kconfig        |   7 +
>>  drivers/video/Makefile       |   2 +-
>>  drivers/video/atmel_hlcdfb.c | 314 ++++++++++++++++++++++++++++++++++++++++++-
>>  3 files changed, 319 insertions(+), 4 deletions(-)
>
> there are many issues with this patch. First it needs re-basing to apply
> on current master branch. The U-Boot image linking fails with this patch
> applied. You change CONFIG_ATMEL_HLCD to CONFIG_VIDEO_ATMEL_HLCD, but
> no board config files in include/config are updated accordingly.
>
> If I update for this option e.g. in at91sam9x5ek.h, the driver doesn't
> build. The building also doesn't work when I enable DM support.
> Please fix all these issues before resubmitting. Thanks.
>
> --
> Anatolij
>