[U-Boot] [PATCH][v2] driver: net: fsl-mc: Use aligned address for MC FW load

[york sun]

On 01/09/2017 10:22 PM, Priyanka Jain wrote:
> Firmware of Management Complex (MC) should be loaded at 512MB aligned
> address. So,
> -mc_ram_addr address calculation in mc_get_dram_addr() is updated to
>  fetch aligned address
> -calculate_mc_private_ram_params() is removed as it is no longer required
> -num_256mb_blocks calculation is moved to mc_init()
>
> Signed-off-by: Priyanka Jain <priyanka.jain at nxp.com>
> ---
> Changes for v2:
>  Update mc_get_dram_addr() logic for adress calculation instead of
>  updating variable mc_ram_addr
>
>  drivers/net/fsl-mc/mc.c |   87 ++++++++++++++++++-----------------------------
>  1 files changed, 33 insertions(+), 54 deletions(-)
>
> diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
> index 46b8a6b..06d373d 100644
> --- a/drivers/net/fsl-mc/mc.c
> +++ b/drivers/net/fsl-mc/mc.c
> @@ -41,6 +41,7 @@ struct fsl_dpbp_obj *dflt_dpbp = NULL;
>  struct fsl_dpio_obj *dflt_dpio = NULL;
>  struct fsl_dpni_obj *dflt_dpni = NULL;
>  static u64 mc_lazy_dpl_addr;
> +u64 mc_ram_addr = 0;

You have global variable with the same name as local variable. It is 
confusing to me. Please avoid using global variable.

York