[U-Boot] [PATCH 12/12] aspeed: Configuration for ast2500 eval board

[Maxim Sloyko]

On Sat, Jan 14, 2017 at 9:14 AM, Simon Glass <sjg at chromium.org> wrote:

> Hi Maxim,
>
> On 4 January 2017 at 12:46, Maxim Sloyko <maxims at google.com> wrote:
> > ---
> >
>
> Commit message?
>
> > ---
> >
> > Signed-off-by: Maxim Sloyko <maxims at google.com>
> > ---
> >  arch/arm/mach-aspeed/ast2500/Kconfig   |  7 +++++++
> >  board/aspeed/evb_ast2500/Kconfig       | 12 ++++++++++++
> >  board/aspeed/evb_ast2500/Makefile      |  1 +
> >  board/aspeed/evb_ast2500/evb_ast2500.c |  1 +
> >  configs/evb-ast2500_defconfig          | 21 +++++++++++++++++++++
> >  include/configs/evb_ast2500.h          | 30
> ++++++++++++++++++++++++++++++
> >  6 files changed, 72 insertions(+)
> >  create mode 100644 board/aspeed/evb_ast2500/Kconfig
> >  create mode 100644 board/aspeed/evb_ast2500/Makefile
> >  create mode 100644 board/aspeed/evb_ast2500/evb_ast2500.c
> >  create mode 100644 configs/evb-ast2500_defconfig
> >  create mode 100644 include/configs/evb_ast2500.h
> >
> > diff --git a/arch/arm/mach-aspeed/ast2500/Kconfig
> b/arch/arm/mach-aspeed/ast2500/Kconfig
> > index c0b448f19e..7397d0c179 100644
> > --- a/arch/arm/mach-aspeed/ast2500/Kconfig
> > +++ b/arch/arm/mach-aspeed/ast2500/Kconfig
> > @@ -3,4 +3,11 @@ if ASPEED_AST2500
> >  config SYS_CPU
> >         default "arm1176"
> >
> > +config TARGET_EVB_AST2500
> > +       bool "Evb-AST2500"
> > +       help
> > +         Evb-AST2500 is Aspeed evaluation board for AST2500 chip.
>
> More details? What peripherals does it provide?
>

Do you mean the hardware or what has been implemented so far?


>
> > +
> > +source "board/aspeed/evb_ast2500/Kconfig"
> > +
> >  endif
> > diff --git a/board/aspeed/evb_ast2500/Kconfig
> b/board/aspeed/evb_ast2500/Kconfig
> > new file mode 100644
> > index 0000000000..73a8ae85f6
> > --- /dev/null
> > +++ b/board/aspeed/evb_ast2500/Kconfig
> > @@ -0,0 +1,12 @@
> > +if TARGET_EVB_AST2500
> > +
> > +config SYS_BOARD
> > +       default "evb_ast2500"
> > +
> > +config SYS_VENDOR
> > +       default "aspeed"
> > +
> > +config SYS_CONFIG_NAME
> > +       default "evb_ast2500"
> > +
> > +endif
> > diff --git a/board/aspeed/evb_ast2500/Makefile
> b/board/aspeed/evb_ast2500/Makefile
> > new file mode 100644
> > index 0000000000..4564098299
> > --- /dev/null
> > +++ b/board/aspeed/evb_ast2500/Makefile
> > @@ -0,0 +1 @@
> > +obj-y += evb_ast2500.o
> > diff --git a/board/aspeed/evb_ast2500/evb_ast2500.c
> b/board/aspeed/evb_ast2500/evb_ast2500.c
> > new file mode 100644
> > index 0000000000..65e11030d8
> > --- /dev/null
> > +++ b/board/aspeed/evb_ast2500/evb_ast2500.c
> > @@ -0,0 +1 @@
> > +#include <common.h>
> > diff --git a/configs/evb-ast2500_defconfig b/configs/evb-ast2500_
> defconfig
> > new file mode 100644
> > index 0000000000..4598f6f418
> > --- /dev/null
> > +++ b/configs/evb-ast2500_defconfig
> > @@ -0,0 +1,21 @@
> > +CONFIG_ARM=y
> > +CONFIG_ARCH_ASPEED=y
> > +CONFIG_ASPEED_AST2500=y
> > +CONFIG_TARGET_EVB_AST2500=y
> > +CONFIG_DEFAULT_DEVICE_TREE="ast2500-evb"
> > +CONFIG_OF_CONTROL=y
> > +CONFIG_DM=y
> > +CONFIG_SYS_MALLOC_F_LEN=0x2000
> > +CONFIG_DISPLAY_CPUINFO=n
> > +CONFIG_SYS_NS16550=y
> > +CONFIG_DM_SERIAL=y
> > +CONFIG_SYSRESET=y
> > +CONFIG_CLK=y
> > +CONFIG_TIMER=y
> > +CONFIG_RAM=y
> > +CONFIG_REGMAP=y
> > +CONFIG_PRE_CONSOLE_BUFFER=y
> > +CONFIG_PRE_CON_BUF_ADDR=0x1e720000
> > +CONFIG_PRE_CON_BUF_SZ=4096
> > +CONFIG_SYS_NO_FLASH=y
> > +CONFIG_CMD_IMLS=n
> > diff --git a/include/configs/evb_ast2500.h
> b/include/configs/evb_ast2500.h
> > new file mode 100644
> > index 0000000000..28d11a2bdf
> > --- /dev/null
> > +++ b/include/configs/evb_ast2500.h
> > @@ -0,0 +1,30 @@
> > +/*
> > + * Copyright (C) 2012-2020  ASPEED Technology Inc.
> > + * Ryan Chen <ryan_chen at aspeedtech.com>
> > + *
> > + * Copyright 2016 Google Inc
> > + *
> > + * SPDX-License-Identifier:     GPL-2.0+
> > + */
> > +
> > +#ifndef __CONFIG_H
> > +#define __CONFIG_H
> > +
> > +#include <configs/aspeed-common.h>
> > +
> > +
>
> Drop extra BLANK LINE
>
> > +#define CONFIG_SYS_MEMTEST_START       (CONFIG_SYS_SDRAM_BASE +
> 0x300000)
> > +#define CONFIG_SYS_MEMTEST_END         (CONFIG_SYS_MEMTEST_START +
> 0x5000000)
> > +
> > +#define CONFIG_SYS_UBOOT_BASE          CONFIG_SYS_TEXT_BASE
> > +
> > +/*
> > + * Memory Info
> > + */
>
> Could be on one line
>
> > +#define CONFIG_SYS_LOAD_ADDR           0x83000000
> > +
> > +#define CONFIG_ENV_IS_NOWHERE          1
>
> You can drop the 1.
>

This has been addressed in v3.


>
> > +
> > +#define CONFIG_ENV_SIZE                        0x20000
> > +
> > +#endif /* __CONFIG_H */
> > --
> > 2.11.0.390.gc69c2f50cf-goog
> >
>
> Regards,
> Simon
>



-- 
*M*axim *S*loyko