[U-Boot] [PATCH 11/12] aspeed: Device Tree for ast2500 Eval Board

Maxim Sloyko maxims at google.com
Tue Jan 17 20:51:17 CET 2017


On Sat, Jan 14, 2017 at 9:14 AM, Simon Glass <sjg at chromium.org> wrote:

> On 4 January 2017 at 12:46, Maxim Sloyko <maxims at google.com> wrote:
> > Signed-off-by: Maxim Sloyko <maxims at google.com>
>
> Please add a commit message explaining where it came from.
>

In v3 top comment in ast2500.dtsi file points to the source. Evb specific
parts and u-boot specific parts were added by me.


>
> > ---
> >
> >  arch/arm/dts/Makefile        |  2 ++
> >  arch/arm/dts/ast2500-evb.dts | 23 +++++++++++++++++++++++
> >  2 files changed, 25 insertions(+)
> >  create mode 100644 arch/arm/dts/ast2500-evb.dts
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> >
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> > index f43746966c..1bee50e237 100644
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -316,6 +316,8 @@ dtb-$(CONFIG_ARCH_BCM283X) += \
> >         bcm2836-rpi-2-b.dtb \
> >         bcm2837-rpi-3-b.dtb
> >
> > +dtb-$(CONFIG_ARCH_ASPEED) += ast2500-evb.dtb
> > +
> >  targets += $(dtb-y)
> >
> >  # Add any required device tree compiler flags here
> > diff --git a/arch/arm/dts/ast2500-evb.dts b/arch/arm/dts/ast2500-evb.dts
> > new file mode 100644
> > index 0000000000..b1a415f7d7
> > --- /dev/null
> > +++ b/arch/arm/dts/ast2500-evb.dts
> > @@ -0,0 +1,23 @@
> > +/dts-v1/;
> > +
> > +#include "ast2500.dtsi"
> > +
> > +/ {
> > +       memory {
> > +               device_type = "memory";
> > +               reg = <0x80000000 0x20000000>;
> > +       };
> > +
> > +       chosen {
> > +               stdout-path = &uart5;
> > +       };
> > +};
> > +
> > +&uart5 {
> > +       u-boot,dm-pre-reloc;
>
> Consider putting this and any other U-Boot-specific things in a
> u-boot*.dtsi file if you have one.
>

This has been addressed in v3


>
> > +       status = "okay";
> > +};
> > +
> > +&sdrammc {
> > +       clock-frequency = <400000000>;
> > +};
> > --
> > 2.11.0.390.gc69c2f50cf-goog
> >
>
> Regards,
> Simon
>



-- 
*M*axim *S*loyko


More information about the U-Boot mailing list