[U-Boot] [PATCH v2 1/4] kconfig: Add API kconfig file

[Warner Losh]

On Tue, Jan 17, 2017 at 12:40 PM, Emmanuel Vadot <manu at bidouilliste.com> wrote:
>
>  Hi Andreas,
>
> On Tue, 17 Jan 2017 18:16:58 +0100
> Andreas Färber <afaerber at suse.de> wrote:
>
>> Am 17.01.2017 um 16:50 schrieb Emmanuel Vadot:
>> > Add kconfig file to enable API support
>> >
>> > Signed-off-by: Emmanuel Vadot <manu at bidouilliste.com>
>> > ---
>> >  Kconfig     | 2 ++
>> >  api/Kconfig | 9 +++++++++
>> >  2 files changed, 11 insertions(+)
>> >  create mode 100644 api/Kconfig
>> >
>> > diff --git a/Kconfig b/Kconfig
>> > index 39a4d938d8..6a93d8820f 100644
>> > --- a/Kconfig
>> > +++ b/Kconfig
>> > @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY
>> >
>> >  endmenu            # Boot images
>> >
>> > +source "api/Kconfig"
>> > +
>> >  source "common/Kconfig"
>> >
>> >  source "cmd/Kconfig"
>> > diff --git a/api/Kconfig b/api/Kconfig
>> > new file mode 100644
>> > index 0000000000..88b4f6c4e5
>> > --- /dev/null
>> > +++ b/api/Kconfig
>> > @@ -0,0 +1,9 @@
>> > +menu "API"
>> > +
>> > +config API
>> > +   bool "Enable U-Boot API"
>> > +   default n
>> > +   help
>> > +     This option enable the U-Boot API.
>>
>> "enables"
>
>  I'll change that, thanks for reviewing.
>
>> Should the help say, e.g., "userspace API" for clarity?
>
>  I don't know, I'm for whatever is best.

It isn't a userspace API, per se, since it isn't used after the kernel
is loaded and booted. It's likely to lead to confusion if use use that
term. The README file calls it "U-Boot machine/arch independent API
for external apps" FWIW, so maybe some variation on that might make
the help text better.

Warner Losh
<imp at freebsd.org>

>> > +
>> > +endmenu
>>
>> Otherwise looks okay, obviously.
>>
>> Regards,
>> Andreas
>>
>> --
>> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>> GF: Felix Imendörffer, Jane Smithard, Graham Norton
>> HRB 21284 (AG Nürnberg)
>
>
> --
> Emmanuel Vadot <manu at bidouilliste.com> <manu at freebsd.org>