[U-Boot] [PATCH v2 17/18] arm: mvebu: Add gdsys ControlCenter-Compact board

Stefan Roese sr at denx.de
Wed Jan 18 18:09:45 CET 2017


On 11.01.2017 16:01, Mario Six wrote:
> From: Dirk Eibach <dirk.eibach at gdsys.cc>
>
> The gdsys ControlCenter Digital board is based on a Marvell Armada 38x
> SOC.
>
> It boots from SPI-Flash but can be configured to boot from SD-card for
> factory programming and testing.
>
> On board peripherals include:
> - 2 x GbE
> - Xilinx Kintex-7 FPGA connected via PCIe
> - mSATA
> - USB3 host
> - Atmel TPM
>
> Signed-off-by: Dirk Eibach <dirk.eibach at gdsys.cc>
> Signed-off-by: Mario Six <mario.six at gdsys.cc>
> ---
> Changes in v2:
>
> * Renamed DTS and board name to include armada-38x
> * Renamed 38x directory to a38x
> * Removed leftover dummy test Kconfig variable from board/gdsys/38x/Kconfig
> * Removed unneeded check for build target in board/gdsys/38x/Makefile
> * Removed duplicated board/gdsys/38x/README
> * Switched MIIPHY to new GPIO API
> * Removed checkboard function
> * Fixed multi-line comment in board/gdsys/controlcenterdc.c
> * Switched to usage of ARRAY_SIZE in board/gdsys/controlcenterdc.c
> * Factored out hydra.{c,h} and ihs_phys.{c,h} from
>   board/gdsys/controlcenterdc.c and removed ifdefs
> * Removed unaddressed TODO from HRE

Thanks for working on this. A few comment still (I didn't look that
closely in this patch as its still huge):

- Are the DT properties okay also for Linux integration? I assume
   that you plan to use Linux on these board, right?

- Is it perhaps possible to move some (most) of the crypto code
   (hre.c) into some common directory, or is this really board
   specific?

Thanks,
Stefan


More information about the U-Boot mailing list