[U-Boot] [PATCH v2] serial, ns16550: bugfix: ns16550 fifo not enabled

[Adam Ford]

On Wed, Jan 18, 2017 at 1:05 AM, Heiko Schocher <hs at denx.de> wrote:
> commit: 65f83802b7a5b "serial: 16550: Add getfcr accessor"
> breaks u-boot commandline working with long commands
> sending to the board.
>
> Since the above patch, you have to setup the fcr register.
>
> For board/archs which enable OF_PLATDATA, the new field
> fcr in struct ns16550_platdata is not filled with a
> default value ...
>
> This leads in not setting up the uarts fifo, which ends
> in problems, when you send long commands to u-boots
> commandline.
>
> Detected this issue with automated tbot tests on am335x
> based shc board.
>

Thanks for fixing this.

> The error does not popup, if you type commands. You need
> to copy&paste a long command to u-boots commandshell
> (or send a long command with tbot)
>
> Possible boards/plattforms with problems:
> ./arch/arm/cpu/arm926ejs/lpc32xx/devices.c
> ./arch/arm/mach-tegra/board.c
> ./board/overo/overo.c
> ./board/quipos/cairo/cairo.c
> ./board/logicpd/omap3som/omap3logic.c
> ./board/logicpd/zoom1/zoom1.c
> ./board/timll/devkit8000/devkit8000.c
> ./board/lg/sniper/sniper.c
> ./board/ti/beagle/beagle.c
> ./drivers/serial/serial_rockchip.c
>
Acked for omap3logic
Tested-by: Adam Ford <aford173 at gmail.com>

> Signed-off-by: Heiko Schocher <hs at denx.de>
> Signed-off-by: Ladislav Michl <ladis at linux-mips.org>
> ---
>
> Changes in v2:
> - added now changes for possible boards/plattforms with problems:
>   ./arch/arm/cpu/arm926ejs/lpc32xx/devices.c
>   ./arch/arm/mach-tegra/board.c
>   ./board/isee/igep00x0/igep00x0.c
>   ./board/overo/overo.c
>   ./board/quipos/cairo/cairo.c
>   ./board/logicpd/omap3som/omap3logic.c
>   ./board/logicpd/zoom1/zoom1.c
>   ./board/timll/devkit8000/devkit8000.c
>   ./board/lg/sniper/sniper.c
>   ./board/ti/beagle/beagle.c
>   ./drivers/serial/serial_rockchip.c
> - Ladislav reported the error on igep00x0 board too, also
>   Adam for the omap3logic board.
> - add Signed-off-by from Ladislav, he also tested the patch
>   for the igep00x0 board.
> - add trailing ',' to new lines, as Tom suggested.

[snip]

> --
> 2.7.4
>