[U-Boot] [PATCH] spl: Add some missing newlines

Simon Glass sjg at chromium.org
Sat Jan 21 04:51:15 CET 2017


Hi Andrew,

On 12 January 2017 at 09:19, Andrew F. Davis <afd at ti.com> wrote:
> Signed-off-by: Andrew F. Davis <afd at ti.com>
> ---
>  common/spl/spl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index a76ea3a603..e43718de62 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -316,7 +316,7 @@ static int boot_from_devices(struct spl_image_info *spl_image,
>                 loader = spl_ll_find_loader(spl_boot_list[i]);
>  #if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
>                 if (loader)
> -                       printf("Trying to boot from %s", loader->name);
> +                       printf("Trying to boot from %s\n", loader->name);
>                 else
>                         puts("SPL: Unsupported Boot Device!\n");
>  #endif
> @@ -389,7 +389,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
>               gd->malloc_ptr / 1024);
>  #endif
>
> -       debug("loaded - jumping to U-Boot...");
> +       debug("loaded - jumping to U-Boot...\n");

I prefer this one as it is, since U-Boot prints a few newlines anyway,
and this way we can have the cursor at the end of the 'jumping' line
until U-Boot starts.

What's the rationale for changing it. Could you add a commit message?

>         spl_board_prepare_for_boot();
>         jump_to_image_no_args(&spl_image);
>  }
> --
> 2.11.0
>

Regards,
Simon


More information about the U-Boot mailing list