[U-Boot] [linux-sunxi] Re: [PATCH 02/12] sunxi: simplify ACTLR.SMP bit set #ifdef

[Maxime Ripard]

On Sun, Jan 22, 2017 at 01:06:47AM +0000, André Przywara wrote:
> > If we still needs it,
> 
> First: we definitely need this symbol, since it guards an implementation
> defined register and the Cortex-A53 does not define it. So we have to
> confine its use to the ARMv7 Cortex CPUs.

Ack.

> > x86 has a CONFIG_SMP symbol, that would be
> > better to just leverage that.
> 
> Sounds tempting, but this seems to be a generic symbol that enables SMP
> support _within_ U-Boot, so it allows multiple cores to execute U-Boot
> code. This is clearly not what we want. Defining it seems to enable
> architecture specific and generic code paths in U-Boot.
> 
> I can rename this symbol if that helps to avoid confusion, for instance
> to read CONFIG_SUNXI_NO_ACTLR_SMP or to CONFIG_CPU_IS_NOT_SMP or
> CONFIG_CPU_IS_UP.

There's nothing sunxi specific about it, the last one is better imho.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170123/b8be54b0/attachment.sig>