[U-Boot] [PATCH] Revert "build: Always build the libfdt python module"

Emmanuel Vadot manu at bidouilliste.com
Mon Jan 23 13:56:25 CET 2017


 Hi Simon,

On Mon, 23 Jan 2017 05:37:50 -0700
Simon Glass <sjg at chromium.org> wrote:

> This appears to cause problems with powerpc:
> 
> +x86_64-linux-gnu-gcc: error: unrecognized command line option ?-melf32ppclinux?
> +error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
> +make[2]: *** [tools/_libfdt.so] Error 1
> +make[1]: *** [tools] Error 2
> +make: *** [sub-make] Error 2

 Why does your hostcc have this cflags ?

 There is a problem where we do not check that we can build python
module (I'll look at how to check this properly) as Heiko just reported
but the fact that your hostcc have an ppc flags just seems wrong, there
must be another problem.

> It may need to be made ARM-specific.
> 
> This reverts commit 1905c8fc711a527ff10550425498bc77e4db9ac3.
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
>  tools/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/Makefile b/tools/Makefile
> index a609d058595..5b81dde4b06 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -111,7 +111,7 @@ fit_check_sign-objs   := $(dumpimage-mkimage-objs) fit_check_sign.o
>  
>  # Build a libfdt Python module if swig is available
>  # Use 'sudo apt-get install swig libpython-dev' to enable this
> -hostprogs-y += \
> +hostprogs-$(CONFIG_SPL_OF_PLATDATA) += \
>  	$(if $(shell which swig 2> /dev/null),_libfdt.so)
>  _libfdt.so-sharedobjs += $(LIBFDT_OBJS)
>  libfdt:
> -- 
> 2.11.0.483.g087da7b7c-goog


-- 
Emmanuel Vadot <manu at bidouilliste.com> <manu at freebsd.org>


More information about the U-Boot mailing list