[U-Boot] [PATCH v4] disk: convert to Kconfig

Tom Rini trini at konsulko.com
Wed Jan 25 04:26:29 CET 2017


On Tue, Jan 24, 2017 at 10:56:55AM +0100, Patrick Delaunay wrote:

> From: Patrick Delaunay <patrick.delaunay at st.com>
> 
> This converts the following to Kconfig:
>            CONFIG_PARTITIONS
>            CONFIG_MAC_PARTITION
>            CONFIG_DOS_PARTITION
>            CONFIG_ISO_PARTITION
>            CONFIG_AMIGA_PARTITION
>            CONFIG_EFI_PARTITION
>            CONFIG_PARTITION_UUIDS
>            CONFIG_PARTITION_TYPE_GUID
> 
> Specific SPL config are added to reduce SPL size
> for some target and solve compilation issues
> 
>            CONFIG_SPL_MAC_PARTITION
>            CONFIG_SPL_DOS_PARTITION
>            CONFIG_SPL_ISO_PARTITION
>            CONFIG_SPL_AMIGA_PARTITION
>            CONFIG_SPL_EFI_PARTITION
> 
> Associated test are updated to the correct CONFIG (SPL or not)
> by using macro CONFIG_IS_ENABLED
> 
> To update the U-Boot code I use :
> 0- Resync with savedefconfig
>    /tools/moveconfig.py -s -Cy
> 
> 1- update defconfig for new SPL option
>    ./tools/moveconfig.py --spl --commit \
>            PARTITIONS MAC_PARTITION DOS_PARTITION \
>            ISO_PARTITION AMIGA_PARTITION EFI_PARTITION \
>            PARTITION_UUIDS PARTITION_TYPE_GUID
> 
>        then replace CONFIG by CONFIG_SPL in defconfig
>        sed -i "s/CONFIG_\(DOS\|EFI\|ISO\|MAC\|AMIGA\)_PARTITION/CONFIG_SPL_\1_PARTITION/" \
>            configs/*
> 
> 2- update defconfig for existing option
>    ./tools/moveconfig.py --commit --yes \
>            PARTITIONS MAC_PARTITION DOS_PARTITION \
>            ISO_PARTITION AMIGA_PARTITION EFI_PARTITION \
>            PARTITION_UUIDS PARTITION_TYPE_GUID
> 
>     => squash the 2 modifications
> 
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay73 at gmail.com>

I played with this a lot tonight.  I think, sadly, we're going the wrong
direction in this conversion.  I believe I had originally suggested a
patch, but that's not right.  Lets get one patch per partition type, as
that will make finding and correcting the conversion easier.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170124/f52cc0ca/attachment.sig>


More information about the U-Boot mailing list