[U-Boot] [PATCH v4 0/7]

[Dinh Nguyen]

On 01/24/2017 09:27 PM, Marek Vasut wrote:
> On 01/25/2017 04:07 AM, Dalon Westergreen wrote:
>> On Tue, 2017-01-24 at 20:58 -0600, Dinh Nguyen wrote:
>>>
>>> On 01/24/2017 11:11 AM, Marek Vasut wrote:
>>>>
>>>> On 01/24/2017 06:05 PM, Dalon Westergreen wrote:
>>>>>
>>>>> From: Dalon Westergreen <dalon.westergreen at intel.com>
>>>>>
>>>>> These patches update the boot and os partition numbers in the 
>>>>> default uboot environment for a number of socfpga boards.  Per
>>>>> request, common environment configurations have been moved to a
>>>>> shared header.
>>>>>
>>>>> Changes in v4:
>>>>>  - Removed extraneous define in socfpga_common.h
>>>>>    and only use CONFIG_EXTRA_ENV_SETTINGS for
>>>>>    common uboot environment
>>>>> Changes in v3:
>>>>>  - Corrected error in common default environment
>>>>>
>>>>> Dalon Westergreen (7):
>>>>>   arm: socfpga: add env settings to common header
>>>>>   arm: socfpga: update de0 nano default environment
>>>>>   arm: socfpga: update cyclone5 socdk default environment
>>>>>   arm: socfpga: update arria5 socdk default environment
>>>>>   arm: socfpga: Update DE1 environment
>>>>>   arm: socfpga: Update SoCKit environment
>>>>>   arm: socfpga: Update sr1500 environment
>>>>>
>>>>>  configs/socfpga_arria5_defconfig         |  1 +
>>>>>  configs/socfpga_cyclone5_defconfig       |  1 +
>>>>>  configs/socfpga_de0_nano_soc_defconfig   |  3 +--
>>>>>  configs/socfpga_de1_soc_defconfig        |  1 +
>>>>>  configs/socfpga_sockit_defconfig         |  1 +
>>>>>  configs/socfpga_sr1500_defconfig         |  1 +
>>>>>  include/configs/socfpga_arria5_socdk.h   | 25 -------------------------
>>>>>  include/configs/socfpga_common.h         | 27 +++++++++++++++++++++++++++
>>>>>  include/configs/socfpga_cyclone5_socdk.h | 25 -------------------------
>>>>>  include/configs/socfpga_de0_nano_soc.h   | 19 +------------------
>>>>>  include/configs/socfpga_de1_soc.h        | 19 +------------------
>>>>>  include/configs/socfpga_sockit.h         | 27 +--------------------------
>>>>>  include/configs/socfpga_sr1500.h         | 25 -------------------------
>>>>>  13 files changed, 36 insertions(+), 139 deletions(-)
>>>>>
>>>>
>>>> Whole series
>>>> Acked-by: Marek Vasut <marex at denx.de>
>>>>
>>>> Dinh, any comments ?
>>>
>>> I thought you had a comment on why this series changes the default
>>> bootfile from a fitImage to zImage. Was that comment addressed?
>>
>> Yes, my comment was that none of the boards were currently using
>> fitimages.
> 
> Yes, it seems the default altera SD card images use zImage + separate
> DTB. I constantly regret bringing bootz into U-Boot tbh, but such are
> the mistakes of youth ...
> 

So I think my only valid comment is for patch "[6/7] arm: socfpga:
Update SoCKit environment"

There is mainline kernel support for this board:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts?id=refs/tags/v4.10-rc5

Dinh