[U-Boot] [PATCH 6/6] arm64: rk3399: add SPL support

Simon Glass sjg at chromium.org
Thu Jan 26 15:23:37 CET 2017


Hi Kever,

On 18 January 2017 at 05:16, Kever Yang <kever.yang at rock-chips.com> wrote:
> Add spl support for rk3399, default with of-platdata enabled.
>
> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
> ---
>
>  arch/arm/Kconfig                              |   1 +
>  arch/arm/dts/rk3399-evb.dts                   |   2 +
>  arch/arm/dts/rk3399.dtsi                      |  44 +++++++
>  arch/arm/include/asm/arch-rockchip/clock.h    |   3 +
>  arch/arm/mach-rockchip/Kconfig                |   2 +
>  arch/arm/mach-rockchip/Makefile               |   1 +
>  arch/arm/mach-rockchip/rk3399-board-spl.c     | 158 ++++++++++++++++++++++++++
>  arch/arm/mach-rockchip/rk3399/syscon_rk3399.c |  40 +++++++
>  configs/evb-rk3399_defconfig                  |  18 +++
>  include/configs/rk3399_common.h               |  11 ++
>  10 files changed, 280 insertions(+)
>  create mode 100644 arch/arm/mach-rockchip/rk3399-board-spl.c

Reviewed-by: Simon Glass <sjg at chromium.org>

But there is too much in this patch. Please split out the patches. My
suggestion:

- syscon additions
- dts/dtsi additions
- arch/arm/Kconfig and include/configs changes
- board-spl.c stuff
- defconfig changes to enable everything

So it should be possible to enable/disable SPL just in the final patch.

Regards,
Simon


More information about the U-Boot mailing list