[U-Boot] [PATCH v2 3/4] mmc: meson: add MMC driver for Meson GX (S905)
Andreas Färber
afaerber at suse.de
Fri Jan 27 00:04:17 CET 2017
Am 25.01.2017 um 20:54 schrieb Heiner Kallweit:
> This driver implements MMC support on Meson GX (S905) based systems.
> It's based on Carlo Caione's work, changes:
> - BLK support added
> - general refactoring
>
> Original author: Carlo Caione <carlo at caione.org>
> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>
There is no such thing as "Original author:". You must keep Carlo's
Signed-off-by line, and if you based this on my incomplete update
attempt at https://github.com/afaerber/u-boot/commits/odroidc2 then also
my Signed-off-by (sorted in chronological order with yours last). I
would've also expected to see Carlo as actual author (--author="...")
instead of such a textual remark.
Jaehoon, please hold off applying this until it has seen some more review.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
More information about the U-Boot
mailing list