[U-Boot] [PATCH 2/7] ti: common: board_detect: commodify ethaddr environment setting code
Roger Quadros
rogerq at ti.com
Fri Jan 27 09:52:41 CET 2017
Tom,
On 26/01/17 19:41, Tom Rini wrote:
> On Thu, Jan 26, 2017 at 03:07:24PM +0200, Roger Quadros wrote:
>
>> As Keystone platforms also need this let's move this function
>> to the common board_detect code.
>
> This exists elsewhere? If so, it should be removed in this patch too.
I'll rewrite the commit log. It doesn't exist anywhere so we're not
moving anything here.
> Also:
>
>> +void __maybe_unused board_ti_set_ethaddr(int index)
>
> We shouldn't need __maybe_unused here as it's a public function and will
> get discarded already if unused.
>
OK.
cheers,
-roger
More information about the U-Boot
mailing list