[U-Boot] [PATCH 6/7] ARM: k2g: setup PRU ethernet MAC addresses

[Tom Rini]

On Fri, Jan 27, 2017 at 10:58:41AM +0200, Roger Quadros wrote:
> 
> On 26/01/17 19:41, Tom Rini wrote:
> > On Thu, Jan 26, 2017 at 03:07:28PM +0200, Roger Quadros wrote:
> > 
> >> PRU ethernet MAC address range is present in the
> >> board EEPROM. Parse it and setup eth?addr
> >> environment variables.
> > [snip]
> >> +#ifdef CONFIG_BOARD_LATE_INIT
> >> +int board_late_init(void)
> >> +{
> >> +	__maybe_unused int rc;
> >> +
> >> +#if !defined(CONFIG_SPL_BUILD) && defined(CONFIG_TI_I2C_BOARD_DETECT)
> > 
> > Just move the #if up to include 'int rc' and we don't need to declare it
> > __maybe_unused then.
> 
> OK.
> > 
> > [snip]
> >> +/* Board Detection EEPROM */
> >> +#define CONFIG_EEPROM_BUS_ADDRESS	0
> >> +#define CONFIG_EEPROM_CHIP_ADDRESS	0x50
> > 
> > Only dra7xx and am57xx use these CONFIG options currently, please
> > migrate them to Kconfig instead of adding another board, thanks!
> > 
> 
> I didn't get this part. In this patch board_k2g.c is using those macros.
> Are you suggesting to move this to Kconfig instead of putting them
> in the board headers?

Correct, move them to Kconfig (and migrate the other two boards).
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170127/28d7e377/attachment.sig>