[U-Boot] [PATCH v4 4/16] common: Move environment choice to Kconfig

[Maxime Ripard]

Hi Jagan,

On Thu, Jan 26, 2017 at 12:49:49PM +0100, Jagan Teki wrote:
> On Mon, Jan 23, 2017 at 2:46 PM, Maxime Ripard
> <maxime.ripard at free-electrons.com> wrote:
> > The environment location is something that might change per board
> > (depending on what storage options are availaible there) or depending on
> > the user choice (when we have several options).
> >
> > Instead of hardcoding it in our configuration header, create a Kconfig
> > choice with the options we use for now, and the symbols that depend on it.
> >
> > Once done, also remove the irrelevant sunxi defines.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> > Reviewed-by: Tom Rini <trini at konsulko.com>
> > ---
> >  common/Kconfig                 | 69 +++++++++++++++++++++++++++++++++++-
> >  include/configs/sunxi-common.h | 14 +------
> >  include/environment.h          |  2 +-
> >  3 files changed, 74 insertions(+), 11 deletions(-)
> >
> > diff --git a/common/Kconfig b/common/Kconfig
> > index a04ee1084fed..e8c88f4ee258 100644
> > --- a/common/Kconfig
> > +++ b/common/Kconfig
> > @@ -158,6 +158,75 @@ config SPI_BOOT
> >
> >  endmenu
> >
> > +menu "Environment"
> > +
> > +if ARCH_SUNXI
> 
> Why we need this arch specific on common, since all these ENV_* are
> common for all?

Precisely because it's common for all. Otherwise we'll get warnings
about the symbol being defined multiple times.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170127/732fbcf1/attachment.sig>