[U-Boot] [PATCH 2/2][v3] armv8: ls1012a: Add support of PPA

[Prabhakar Kushwaha]

> -----Original Message-----
> From: york sun
> Sent: Saturday, January 28, 2017 2:10 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; u-
> boot at lists.denx.de
> Cc: Z.Q. Hou <zhiqiang.hou at nxp.com>; Abhimanyu Saini
> <abhimanyu.saini at nxp.com>
> Subject: Re: [PATCH 2/2][v3] armv8: ls1012a: Add support of PPA
> 
> On 01/26/2017 08:09 PM, Prabhakar Kushwaha wrote:
> > The PPA implements PSCI which requires for power managment.
> >
> > Added support of PPA for LS1012AQDS, LS1012ARDB and LS1012AFRDM.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> > Signed-off-by: Abhimanyu Saini <abhimanyu.saini at nxp.com>
> > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>
> > ---
> > Changes for v2: Enabled FSL_LS_PPA
> > Changes for v3: Rebased and updated as per latest PPA code
> >
> >  board/freescale/ls1012afrdm/ls1012afrdm.c | 6 ++++++
> >  board/freescale/ls1012aqds/ls1012aqds.c   | 7 +++++++
> >  board/freescale/ls1012ardb/ls1012ardb.c   | 6 ++++++
> >  configs/ls1012afrdm_qspi_defconfig        | 1 +
> >  configs/ls1012aqds_qspi_defconfig         | 1 +
> >  configs/ls1012ardb_qspi_defconfig         | 1 +
> >  6 files changed, 22 insertions(+)
> >
> > diff --git a/board/freescale/ls1012afrdm/ls1012afrdm.c
> b/board/freescale/ls1012afrdm/ls1012afrdm.c
> > index c2432c3..789cae2 100644
> > --- a/board/freescale/ls1012afrdm/ls1012afrdm.c
> > +++ b/board/freescale/ls1012afrdm/ls1012afrdm.c
> > @@ -9,6 +9,9 @@
> >  #include <asm/io.h>
> >  #include <asm/arch/clock.h>
> >  #include <asm/arch/fsl_serdes.h>
> > +#ifdef CONFIG_FSL_LS_PPA
> > +#include <asm/arch/ppa.h>
> > +#endif
> 
> Do you really need #ifdef here?
> 

Yes, if CONFIG_FSL_LS_PPA is undefined then  ppa_init() should not be called. 
As ppa_init declaration is present in ppa.h. So need to remove inclusion of ppa.h also. 

--prabhakar