[U-Boot] [RFC PATCH 5/5] rockchip: mkimage: use spl_boot0 for all Rockchip SoCs

Andy Yan andyshrk at gmail.com
Thu Jun 1 01:11:33 UTC 2017


Hi Philipp:

2017-05-31 18:58 GMT+08:00 Dr. Philipp Tomsich <
philipp.tomsich at theobroma-systems.com>:

> Now that there are no remaining cases where (spl_boot0 == false), we can
> drop the spl_boot0 field from struct spl_info and also remove the if-check
> (leaving only the code-path for true in place).
>
>

  I think we still have one case: use mkimage to pack ddr.bin  from
rockchip as spl.bin.



> There should be no need to keep the legacy code-path around, as GIT will
> always remember them anyway.
>
> Regards,
> Philipp.
>
> > On 31 May 2017, at 12:50, Kever Yang <kever.yang at rock-chips.com> wrote:
> >
> > Enable the spl_boot0 in SPL and use the pre-padding TAG memory,
> > the mkimage do not need to pad it but only need to replace the value
> > with correct TAG value.
> >
> > Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
> > ---
> >
> > tools/rkcommon.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/rkcommon.c b/tools/rkcommon.c
> > index 836a5a5..b58dfae 100644
> > --- a/tools/rkcommon.c
> > +++ b/tools/rkcommon.c
> > @@ -68,10 +68,10 @@ struct spl_info {
> > };
> >
> > static struct spl_info spl_infos[] = {
> > -     { "rk3036", "RK30", 0x1000, false, false },
> > -     { "rk3188", "RK31", 0x8000 - 0x800, true, false },
> > -     { "rk3288", "RK32", 0x8000, false, false },
> > -     { "rk3328", "RK32", 0x8000 - 0x1000, false, false },
> > +     { "rk3036", "RK30", 0x1000, false, true },
> > +     { "rk3188", "RK31", 0x8000 - 0x800, true, true },
> > +     { "rk3288", "RK32", 0x8000, false, true },
> > +     { "rk3328", "RK32", 0x8000 - 0x1000, false, true },
> >       { "rk3399", "RK33", 0x20000, false, true },
> > };
> >
> > --
> > 1.9.1
> >
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
>


More information about the U-Boot mailing list