[U-Boot] [PATCH v2 07/28] power: regulator: Add more debugging and fix a missing newline

[Jaehoon Chung]

On 06/01/2017 08:57 AM, Simon Glass wrote:
> This file does not report a few possible errors and one message is missing
> a newline. Fix these.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

And CC'd correct Lukasz's mail account.


> ---
> 
> Changes in v2: None
> 
>  drivers/power/regulator/regulator-uclass.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c
> index a42f80bb2b..0a1d1b36c0 100644
> --- a/drivers/power/regulator/regulator-uclass.c
> +++ b/drivers/power/regulator/regulator-uclass.c
> @@ -146,8 +146,10 @@ int regulator_get_by_platname(const char *plat_name, struct udevice **devp)
>  
>  	for (ret = uclass_find_first_device(UCLASS_REGULATOR, &dev); dev;
>  	     ret = uclass_find_next_device(&dev)) {
> -		if (ret)
> +		if (ret) {
> +			debug("regulator %s, ret=%d\n", dev->name, ret);
>  			continue;
> +		}
>  
>  		uc_pdata = dev_get_uclass_platdata(dev);
>  		if (!uc_pdata || strcmp(plat_name, uc_pdata->name))
> @@ -156,7 +158,7 @@ int regulator_get_by_platname(const char *plat_name, struct udevice **devp)
>  		return uclass_get_device_tail(dev, 0, devp);
>  	}
>  
> -	debug("%s: can't find: %s\n", __func__, plat_name);
> +	debug("%s: can't find: %s, ret=%d\n", __func__, plat_name, ret);
>  
>  	return -ENODEV;
>  }
> @@ -219,7 +221,7 @@ int regulator_autoset_by_name(const char *platname, struct udevice **devp)
>  	if (devp)
>  		*devp = dev;
>  	if (ret) {
> -		debug("Can get the regulator: %s!", platname);
> +		debug("Can get the regulator: %s (err=%d)\n", platname, ret);
>  		return ret;
>  	}
>  
>