[U-Boot] [PATCH] buildman: Translate more strings to latin-1

[Simon Glass]

Hi Daniel,

On 31 May 2017 at 07:40, Daniel Schwierzeck
<daniel.schwierzeck at gmail.com> wrote:
> This is a follow-up patch for commit fbeb33752999e7317113199ef89873d6b6916814.
>
> This fixes following exception:
>
> Exception in thread Thread-7:
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
>     self.run()
>   File "/u-boot/tools/buildman/builderthread.py", line 475, in run
>     self.RunJob(job)
>   File "/u-boot/tools/buildman/builderthread.py", line 456, in RunJob
>     self._WriteResult(result, job.keep_outputs)
>   File "/u-boot/tools/buildman/builderthread.py", line 333, in _WriteResult
>     print >>fd, dump_result.stdout,
> UnicodeEncodeError: 'ascii' codec can't encode characters in position 75-76: ordinal not in range(128)
>
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
>
> ---
>
>  tools/buildman/builderthread.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
> index acaf5007f5..0a460878f3 100644
> --- a/tools/buildman/builderthread.py
> +++ b/tools/buildman/builderthread.py
> @@ -330,7 +330,7 @@ class BuilderThread(threading.Thread):
>                      objdump = self.builder.GetObjdumpFile(result.commit_upto,
>                                      result.brd.target, fname)
>                      with open(objdump, 'w') as fd:
> -                        print >>fd, dump_result.stdout,
> +                        print >>fd, dump_result.stdout.encode('latin-1', 'ignore'),

I am worried that this will produce gibberish in the output. Do you
know what specific characters are causing problems? Can we encode to
utf-8? BTW I recently sent a patman series to try to resolve unicode
issues in patman.

>                      for line in dump_result.stdout.splitlines():
>                          fields = line.split()
>                          if len(fields) > 5 and fields[1] == '.rodata':
> --
> 2.13.0
>

Regards,
Simon