[U-Boot] [PATCH v3 1/2] drivers: net: fsl-mc: Link MC boot to PHY_RESET_R

[york sun]

On 05/24/2017 09:40 AM, Bogdan Purcareata wrote:
> DPAA2 platforms boot the Management Complex based on the u-boot env
> variable "mcinitcmd". Instead of doing this step on each platform
> individually, define a single mc_env_boot function in the MC driver,
> since it's semantically tied to it.
> 
> Call the function in a per-board reset_phy hook, as it gets called at a
> later moment, when all board PHY devices have been initialized.
> 
> Signed-off-by: Bogdan Purcareata <bogdan.purcareata at nxp.com>
> Signed-off-by: Heinz Wrobel <heinz.wrobel at nxp.com>
> ---
> v2 -> v3:
> - add dummy reset_phy() implementation in board/freescale/ls2080a/ls2080a.c
>    for proper compilation on ls2080a_simu and ls2080a_emu
> 
> v1 -> v2:
> - keep the reset_phy implementation on each board; some boards might
>    want to do something else besides booting the MC.
> 
>   board/freescale/ls2080a/ls2080a.c          |  6 ++++++
>   board/freescale/ls2080aqds/eth.c           | 13 ++++++-------
>   board/freescale/ls2080ardb/eth_ls2080rdb.c | 14 ++++++++------
>   drivers/net/fsl-mc/mc.c                    | 16 ++++++++++++++++
>   include/configs/ls2080a_common.h           |  5 +++++
>   include/fsl-mc/fsl_mc.h                    |  1 +
>   6 files changed, 42 insertions(+), 13 deletions(-)
> 

<snip>

> diff --git a/include/fsl-mc/fsl_mc.h b/include/fsl-mc/fsl_mc.h
> index ffe6da5..60088ec 100644
> --- a/include/fsl-mc/fsl_mc.h
> +++ b/include/fsl-mc/fsl_mc.h
> @@ -61,4 +61,5 @@ u64 mc_get_dram_addr(void);
>   unsigned long mc_get_dram_block_size(void);
>   int fsl_mc_ldpaa_init(bd_t *bis);
>   int fsl_mc_ldpaa_exit(bd_t *bd);
> +void mc_env_boot(void);
>   #endif
> 

I see compiling warning for this function
"
warning: implicit declaration of function 'mc_env_boot' 
[-Wimplicit-function-declaration]
"

Don't you need to include this header file in 
board/freescale/ls2080ardb/eth_ls2080rdb.c?

York