[U-Boot] [RFC PATCH 5/5] rockchip: mkimage: use spl_boot0 for all Rockchip SoCs

[Kever Yang]

Philipp and Andy,


I will remove the "spl_boot0 == false" case in next version.

Rockchip ddr.bin is always with pre-paded TAG.

Thanks,
- Kever
On 06/01/2017 03:41 PM, Dr. Philipp Tomsich wrote:
>> On 01 Jun 2017, at 03:11, Andy Yan <andyshrk at gmail.com> wrote:
>>
>> Hi Philipp:
>>
>> 2017-05-31 18:58 GMT+08:00 Dr. Philipp Tomsich <philipp.tomsich at theobroma-systems.com>:
>> Now that there are no remaining cases where (spl_boot0 == false), we can
>> drop the spl_boot0 field from struct spl_info and also remove the if-check
>> (leaving only the code-path for true in place).
>>
>>
>>
>>    I think we still have one case: use mkimage to pack ddr.bin  from rockchip as spl.bin.
> Excellent point! I completely missed that use-case.
>
> However, then we’d need to implement support (an additional commandline flag?) for
> communicating this into mkimage: with the current state of the code, the new code path
> (i.e. assuming its a pre-padded image) will be always be taken and ddr.bin can’t be processed.
>
> The alternative would be to clearly document that a ddr.bin needs to be prepadded and then
> pad the ddr.bin manually before passing it to mkimage.
>
> I have no preference either way, but would recommend/request that if we leave the code-path
> in, then there should be a way to invoke it.
>
> Best regards,
> Philipp.
>
>