[U-Boot] [PATCH v4 6/9] rockchip: video: split RK3228-specific part off from rk_hdmi

[Simon Glass]

On 31 May 2017 at 09:59, Philipp Tomsich
<philipp.tomsich at theobroma-systems.com> wrote:
> To prepare for the addition of RK3399 HDMI support, the HDMI driver is
> refactored and broken into a chip-specific and a generic part.  This
> change adds the internal interfaces, makes common/reusable functions
> externally visible and splits the RK3228 driver into a separate file.
>
> For the probing of regulators, we reuse the infrastructure created
> during the VOP refactoring... i.e. we simply call into the helper
> function defined for the VOP.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>
> Version-changes: 4
> - add this path (as part of breaking up the large HDMI change for the RK3399)
>
> ---
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>  drivers/video/rockchip/Makefile      |   3 +-
>  drivers/video/rockchip/rk3288_hdmi.c | 116 +++++++++++++++++++++++++++++++++++
>  drivers/video/rockchip/rk_hdmi.c     | 105 +++++--------------------------
>  drivers/video/rockchip/rk_hdmi.h     |  32 ++++++++++
>  4 files changed, 166 insertions(+), 90 deletions(-)
>  create mode 100644 drivers/video/rockchip/rk3288_hdmi.c
>  create mode 100644 drivers/video/rockchip/rk_hdmi.h
>

Reviewed-by: Simon Glass <sjg at chromium.org>

Again please comment the header-file functions:

> +int rk_hdmi_read_edid(struct udevice *dev, u8 *buf, int buf_size);
> +void rk_hdmi_probe_regulators(struct udevice *dev,
> +                             const char * const *names, int cnt);
> +int rk_hdmi_ofdata_to_platdata(struct udevice *dev);
> +int rk_hdmi_probe(struct udevice *dev);
> +
> +#endif
> --
> 1.9.1
>