[U-Boot] [PATCH 4/4] rockchip: dts: rk3399-puma: select DRAM timing via Kconfig

Simon Glass sjg at chromium.org
Mon Jun 5 21:33:17 UTC 2017


Hi Philipp,

On 1 June 2017 at 20:55, Simon Glass <sjg at chromium.org> wrote:
> On 31 May 2017 at 10:16, Philipp Tomsich
> <philipp.tomsich at theobroma-systems.com> wrote:
>> The RK3399-Q7 has multiple build-options for its DRAM configuration,
>> including the timing of the DRAM components populated.
>>
>> While DDR3-1600 is the standard configuration, custom-configurations
>> are available with DDR3-1333 (for a further cost-optimisation) and
>> with DDR3-1866 (as a premium option).
>>
>> To simplify our test automation (without the need to maintain 3
>> different defconfigs) and customer evaluation, we make this selectable
>> via Kconfig.
>>
>> Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>> ---
>>
>>  arch/arm/dts/rk3399-puma.dts                |  8 +++++++
>>  board/theobroma-systems/puma_rk3399/Kconfig | 37 +++++++++++++++++++++++++++++
>>  2 files changed, 45 insertions(+)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Unfortunately this break various boards including firefly-rk3288.

Instead of the #ifdef can you please add a separate .dts for each
variant, with each including a .dtsi with the rest of it?

Regards,
Simon


More information about the U-Boot mailing list