[U-Boot] [PATCH v7 04/10] usb: phy: Add STi USB2 PHY

[Patrice CHOTARD]

Hi Marek

On 06/05/2017 01:21 PM, Marek Vasut wrote:
> On 06/05/2017 08:58 AM, Patrice CHOTARD wrote:
>> Hi Marek
>>
>> On 06/03/2017 08:08 AM, Marek Vasut wrote:
>>> On 06/01/2017 02:05 PM, patrice.chotard at st.com wrote:
>>>> From: Patrice Chotard <patrice.chotard at st.com>
>>>>
>>>> This is the generic phy driver for the picoPHY ports
>>>> used by USB2/1.1 controllers. It is found on STiH407 SoC
>>>> family from STMicroelectronics.
>>>>
>>>> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
>>>> Reviewed-by: Marek Vasut <marex at denx.de>
>>>> ---
>>>> v7:	_ replace fdtdec_parse_phandle_with_args() by dev_read_phandle_with_args()
>>>> 	_ replace uclass_get_device_by_of_offset() by uclass_get_device_by_ofnode()
>>>>
>>>
>>> You should drop RB if you do significant changes.
>>>
>>>>
>>>> v5:	_ add Reviewed-by: Marek Vasut <marex at denx.de>
>>>>
>>>> v4:	_ update to use the new PHY uclass currently available on dm-next branch
>>>>
>>>> v3: 	_ convert driver to USB PHY uclass
>>>>
>>>> v2:	_ replace bitfield_replace() by clrsetbits_le32()
>>>>
>>>>    doc/device-tree-bindings/phy/phy-stih407-usb.txt |  24 +++
>>>>    drivers/phy/Kconfig                              |   8 +
>>>>    drivers/phy/Makefile                             |   1 +
>>>>    drivers/phy/sti_usb_phy.c                        | 181 +++++++++++++++++++++++
>>>>    4 files changed, 214 insertions(+)
>>>>    create mode 100644 doc/device-tree-bindings/phy/phy-stih407-usb.txt
>>>>    create mode 100644 drivers/phy/sti_usb_phy.c
>>>>
>>>> diff --git a/doc/device-tree-bindings/phy/phy-stih407-usb.txt b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
>>>> new file mode 100644
>>>> index 0000000..de6a706
>>>> --- /dev/null
>>>> +++ b/doc/device-tree-bindings/phy/phy-stih407-usb.txt
>>>> @@ -0,0 +1,24 @@
>>>> +ST STiH407 USB PHY controller
>>>> +
>>>> +This file documents the dt bindings for the usb picoPHY driver which is the PHY for both USB2 and USB3
>>>> +host controllers (when controlling usb2/1.1 devices) available on STiH407 SoC family from STMicroelectronics.
>>>> +
>>>> +Required properties:
>>>> +- compatible		: should be "st,stih407-usb2-phy"
>>>> +- st,syscfg		: phandle of sysconfig bank plus integer array containing phyparam and phyctrl register offsets
>>>> +- resets		: list of phandle and reset specifier pairs. There should be two entries, one
>>>> +			  for the whole phy and one for the port
>>>> +- reset-names		: list of reset signal names. Should be "global" and "port"
>>>> +See: Documentation/devicetree/bindings/reset/st,sti-powerdown.txt
>>>> +See: Documentation/devicetree/bindings/reset/reset.txt
>>>> +
>>>> +Example:
>>>> +
>>>> +usb2_picophy0: usbpicophy at f8 {
>>>
>>> This example uses address, but has no reg property ?
>>
>> Agree, but following advices from Arnd Bergman about not mixing address
>> space and sysconfig registers int the reg property, the reg property was
>> removed.
>>
>> For more details, see https://patches.linaro.org/patch/44081/
> 
> Then you should remove it from usbpicophy at f8 too .

Ok

> 
> [...]
>