[U-Boot] [PATCH 2/2] power: regulator: lp87565: add regulator support
Simon Glass
sjg at chromium.org
Tue Jun 6 21:08:27 UTC 2017
Hi Keerthy,
On 1 June 2017 at 23:19, Keerthy <j-keerthy at ti.com> wrote:
> The driver provides regulator set/get voltage
> enable/disable functions for lp87565 family of PMICs.
>
> Signed-off-by: Keerthy <j-keerthy at ti.com>
> ---
> drivers/power/regulator/Kconfig | 8 ++
> drivers/power/regulator/Makefile | 1 +
> drivers/power/regulator/lp87565_regulator.c | 199 ++++++++++++++++++++++++++++
> 3 files changed, 208 insertions(+)
> create mode 100644 drivers/power/regulator/lp87565_regulator.c
>
> diff --git a/drivers/power/regulator/Kconfig b/drivers/power/regulator/Kconfig
> index ef057e0..203292f 100644
> --- a/drivers/power/regulator/Kconfig
> +++ b/drivers/power/regulator/Kconfig
> @@ -149,3 +149,11 @@ config DM_REGULATOR_LP873X
> This enables implementation of driver-model regulator uclass
> features for REGULATOR LP873X and the family of LP873X PMICs.
> The driver implements get/set api for: value and enable.
> +
> +config DM_REGULATOR_LP87565
> + bool "Enable driver for LP87565 PMIC regulators"
> + depends on PMIC_LP87565
> + ---help---
> + This enables implementation of driver-model regulator uclass
> + features for REGULATOR LP87565 and the family of LP87565 PMICs.
> + The driver implements get/set api for value and enable.
What regulators are available? LDOs / bucks ?
> diff --git a/drivers/power/regulator/Makefile b/drivers/power/regulator/Makefile
> index 3e01021..ce14d08 100644
> --- a/drivers/power/regulator/Makefile
> +++ b/drivers/power/regulator/Makefile
> @@ -18,3 +18,4 @@ obj-$(CONFIG_DM_REGULATOR_SANDBOX) += sandbox.o
> obj-$(CONFIG_REGULATOR_TPS65090) += tps65090_regulator.o
> obj-$(CONFIG_$(SPL_)DM_REGULATOR_PALMAS) += palmas_regulator.o
> obj-$(CONFIG_$(SPL_)DM_REGULATOR_LP873X) += lp873x_regulator.o
> +obj-$(CONFIG_$(SPL_)DM_REGULATOR_LP87565) += lp87565_regulator.o
> diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regulator/lp87565_regulator.c
> new file mode 100644
> index 0000000..f6a552e
> --- /dev/null
> +++ b/drivers/power/regulator/lp87565_regulator.c
> @@ -0,0 +1,199 @@
> +/*
> + * (C) Copyright 2016
> + * Texas Instruments Incorporated, <www.ti.com>
> + *
> + * Keerthy <j-keerthy at ti.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <fdtdec.h>
> +#include <errno.h>
> +#include <dm.h>
> +#include <i2c.h>
> +#include <power/pmic.h>
> +#include <power/regulator.h>
> +#include <power/lp87565.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +static const char lp87565_buck_ctrl1[LP87565_BUCK_NUM] = {0x2, 0x4, 0x6, 0x8, 0x2, 0x6};
> +static const char lp87565_buck_vout[LP87565_BUCK_NUM] = {0xA, 0xC, 0xE, 0x10, 0xA, 0xE };
> +
> +static int lp87565_buck_enable(struct udevice *dev, int op, bool *enable)
> +{
> + int ret;
> + unsigned int adr;
> + struct dm_regulator_uclass_platdata *uc_pdata;
> +
> + uc_pdata = dev_get_uclass_platdata(dev);
> + adr = uc_pdata->ctrl_reg;
> +
> + ret = pmic_reg_read(dev->parent, adr);
> + if (ret < 0)
> + return ret;
> +
> + if (op == PMIC_OP_GET) {
> + ret &= LP87565_BUCK_MODE_MASK;
> +
> + if (ret)
> + *enable = true;
> + else
> + *enable = false;
> +
> + return 0;
> + } else if (op == PMIC_OP_SET) {
> + if (*enable)
> + ret |= LP87565_BUCK_MODE_MASK;
> + else
> + ret &= ~(LP87565_BUCK_MODE_MASK);
Drop ()
> + ret = pmic_reg_write(dev->parent, adr, ret);
> + if (ret)
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int lp87565_buck_volt2hex(int uV)
I'm a bit unsure about the word 'hex' here. Would it be better to use 'val'?
> +{
> + if (uV > LP87565_BUCK_VOLT_MAX)
> + return -EINVAL;
> + else if (uV > 1400000)
> + return (uV - 1420000) / 20000 + 0x9E;
> + else if (uV > 730000)
> + return (uV - 735000) / 5000 + 0x18;
> + else if (uV >= 500000)
> + return (uV - 500000) / 10000;
> + else
> + return -EINVAL;
> +}
> +
> +static int lp87565_buck_hex2volt(int hex)
> +{
> + if (hex > LP87565_BUCK_VOLT_MAX_HEX)
> + return -EINVAL;
> + else if (hex > 0x9D)
> + return 1400000 + (hex - 0x9D) * 20000;
> + else if (hex > 0x17)
> + return 730000 + (hex - 0x17) * 5000;
> + else if (hex >= 0x0)
> + return 500000 + hex * 10000;
> + else
> + return -EINVAL;
> +}
> +
> +static int lp87565_buck_val(struct udevice *dev, int op, int *uV)
> +{
> + unsigned int hex, adr;
> + int ret;
> + struct dm_regulator_uclass_platdata *uc_pdata;
> +
> + uc_pdata = dev_get_uclass_platdata(dev);
> +
> + if (op == PMIC_OP_GET)
> + *uV = 0;
> +
> + adr = uc_pdata->volt_reg;
> +
> + ret = pmic_reg_read(dev->parent, adr);
> + if (ret < 0)
> + return ret;
> +
> + if (op == PMIC_OP_GET) {
> + ret &= LP87565_BUCK_VOLT_MASK;
> + ret = lp87565_buck_hex2volt(ret);
> + if (ret < 0)
> + return ret;
> + *uV = ret;
> +
> + return 0;
> + }
> +
> + hex = lp87565_buck_volt2hex(*uV);
> + if (hex < 0)
> + return hex;
> +
> + ret &= 0x0;
> + ret |= hex;
Can you just use ret = hex ?
> +
> + ret = pmic_reg_write(dev->parent, adr, ret);
> +
> + return ret;
> +}
> +
> +static int lp87565_buck_probe(struct udevice *dev)
> +{
> + struct dm_regulator_uclass_platdata *uc_pdata;
> + int idx;
> +
> + uc_pdata = dev_get_uclass_platdata(dev);
> + uc_pdata->type = REGULATOR_TYPE_BUCK;
> +
> + idx = dev->driver_data;
> + if (idx == 0 || idx == 1 || idx == 2 || idx == 3) {
> + debug("Single phase regulator\n");
> + } else if (idx == 23) {
> + idx = 5;
> + } else if (idx == 10) {
> + idx = 4;
> + } else {
> + printf("Wrong ID for regulator\n");
> + return -1;
-EINVAL or something like that. -1 is -EPERM
> + }
> +
> + uc_pdata->ctrl_reg = lp87565_buck_ctrl1[idx];
> + uc_pdata->volt_reg = lp87565_buck_vout[idx];
> +
> + return 0;
> +}
> +
> +static int buck_get_value(struct udevice *dev)
> +{
> + int uV;
> + int ret;
> +
> + ret = lp87565_buck_val(dev, PMIC_OP_GET, &uV);
> + if (ret)
> + return ret;
> +
> + return uV;
> +}
> +
> +static int buck_set_value(struct udevice *dev, int uV)
> +{
> + return lp87565_buck_val(dev, PMIC_OP_SET, &uV);
> +}
> +
> +static bool buck_get_enable(struct udevice *dev)
> +{
> + bool enable = false;
> + int ret;
> +
> +
> + ret = lp87565_buck_enable(dev, PMIC_OP_GET, &enable);
> + if (ret)
> + return ret;
> +
> + return enable;
> +}
> +
> +static int buck_set_enable(struct udevice *dev, bool enable)
> +{
> + return lp87565_buck_enable(dev, PMIC_OP_SET, &enable);
> +}
> +
> +static const struct dm_regulator_ops lp87565_buck_ops = {
> + .get_value = buck_get_value,
> + .set_value = buck_set_value,
> + .get_enable = buck_get_enable,
> + .set_enable = buck_set_enable,
> +};
> +
> +U_BOOT_DRIVER(lp87565_buck) = {
> + .name = LP87565_BUCK_DRIVER,
> + .id = UCLASS_REGULATOR,
> + .ops = &lp87565_buck_ops,
> + .probe = lp87565_buck_probe,
> +};
> --
> 1.9.1
>
Regards,
Simon
More information about the U-Boot
mailing list