[U-Boot] [linux-sunxi] Re: [RFC PATCH 5/8] sunxi: Add CPUCFG register definitions for A80/A83T SoCs

[Chen-Yu Tsai]

On Wed, Jun 7, 2017 at 2:58 PM, Icenowy Zheng <icenowy at aosc.io> wrote:
>
>
> 于 2017年6月7日 GMT+08:00 下午2:44:21, Maxime Ripard <maxime.ripard at free-electrons.com> 写到:
>>On Wed, Jun 07, 2017 at 08:47:18AM +0800, Icenowy Zheng wrote:
>>> diff --git a/arch/arm/include/asm/arch-sunxi/cpucfg_sun4i.h
>>b/arch/arm/include/asm/arch-sunxi/cpucfg_sun4i.h
>>> new file mode 100644
>>> index 0000000000..af1a1d56c9
>>> --- /dev/null
>>> +++ b/arch/arm/include/asm/arch-sunxi/cpucfg_sun4i.h
>>> @@ -0,0 +1,68 @@
>>> +/*
>>> + * Sunxi A31 CPUCFG register definition.
>>
>>Calling that file sun4i doesn't make much sense, the A31 is part of
>>sun6i, and the cpucfg block wasn't there with sun4i.
>
> So... call it sun6i?

No. The original cpucfg.h is for the A20 and the A31, and all the single
cluster SoC that followed.

The A83T's CPUCFG has more in common with the A80. You can just keep
cpucfg.h unchanged, and rename the new one cpucfg-mcpm.h. You don't
even need the generic cpucfg.h stub header you added.

Regards
ChenYu