[U-Boot] [PATCH 1/5] mmc: sh_sdhi: Fix Kconfig entry

[Marek Vasut]

On 06/07/2017 05:29 AM, Jaehoon Chung wrote:
> Hi Marek,
> 
> On 06/05/2017 10:32 PM, Marek Vasut wrote:
>> On 06/05/2017 03:11 PM, Jaehoon Chung wrote:
>>> Hi,
>>
>> Hi,
>>
>>> On 2017년 06월 05일 20:57, Marek Vasut wrote:
>>>> On 05/31/2017 07:07 AM, Nobuhiro Iwamatsu wrote:
>>>>> Hi!
>>>>>
>>>>> 2017-05-31 11:06 GMT+09:00 Jaehoon Chung <jh80.chung at samsung.com>:
>>>>>> On 05/31/2017 07:59 AM, Nobuhiro Iwamatsu wrote:
>>>>>>> Hi, Jaehoon.
>>>>>>>
>>>>>>> Could you pickup this patch series to your mmc repository, and PR to u-boot?
>>>>>>
>>>>>> Sure, I will pick this patch series. After that, i will do PR..
>>>>>> But i have sent the PR about a few days ago..but it doesn't accept yet..
>>>>>> After accepting it, i will resend PR.
>>>>>
>>>>> I see. Thanks for your great work!
>>>>
>>>> Hi, any news ? RC1 is out and I don't see this in RC1 .
>>>
>>> When i had tested the buildman, there are build error with [PATCH 3/5]
>>>
>>>
>>>   aarch64:  +   r8a7795_salvator-x
>>> +board/renesas/salvator-x/salvator-x.c: In function 'board_mmc_init':
>>> +board/renesas/salvator-x/salvator-x.c:196:7: error: 'SH_SDHI_QUIRK_64BIT_BUF' undeclared (first use in this function)
>>> +       SH_SDHI_QUIRK_64BIT_BUF);
>>> +       ^~~~~~~~~~~~~~~~~~~~~~~
>>> +board/renesas/salvator-x/salvator-x.c:196:7: note: each undeclared identifier is reported only once for each function it appears in
>>> +make[2]: *** [board/renesas/salvator-x/salvator-x.o] Error 1
>>> +make[1]: *** [board/renesas/salvator-x] Error 2
>>> +make[1]: *** wait: No child processes.  Stop.
>>> +make: *** [sub-make] Error 2
>>>
>>> So i had sent the email about fixing it.
>>
>> I didn't receive that email.
>>
>>> i didn't check with latest u-boot.
>>> but at that time, i could not apply it with building error.
>>
>> Builds fine for me after applying all the patches on u-boot/master ,
>> commit dd31be21bf .
>>
>> I guess what you see is that if you apply only 1/5 , the build will
>> choke on issue which is already present. The fix is simple really,
>> apply the patches in the order 2,3,4,5,1 and you won't trigger the
>> issue and your build will pass. In fact, patch 3 adds the missing macro
>> and thus fixes the issue which patch 1 triggers. I don't think this
>> requires me to resubmit the patches with no changes in them. Then you
>> can send PR.
> 
> Applied to u-boot-mmc after ordering 2,3,4,5,1.
> Will send PR. At that time, i will add you.

Excellent, thanks.

-- 
Best regards,
Marek Vasut