[U-Boot] [PATCH v2 1/2] power: pmic: lp87565: Add the basic pmic support

[Keerthy]

On Wednesday 07 June 2017 06:28 PM, Jaehoon Chung wrote:
> Hi Keerthy,
> 
> On 06/07/2017 01:08 PM, Keerthy wrote:
>> Add support to bind the regulators/child nodes with the pmic.
>>
>> Signed-off-by: Keerthy <j-keerthy at ti.com>
>> ---
>>
>> Changes in v2:
>>
>>   * Used dev_read_subnode function to fetch the regulators node.
>>  
>>  drivers/power/pmic/Kconfig   |  7 ++++
>>  drivers/power/pmic/Makefile  |  1 +
>>  drivers/power/pmic/lp87565.c | 85 ++++++++++++++++++++++++++++++++++++++++++++
>>  include/power/lp87565.h      | 12 +++++++
>>  4 files changed, 105 insertions(+)
>>  create mode 100644 drivers/power/pmic/lp87565.c
>>  create mode 100644 include/power/lp87565.h
>>
>> diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig
>> index 3f50c12..e3f9e4d 100644
>> --- a/drivers/power/pmic/Kconfig
>> +++ b/drivers/power/pmic/Kconfig
>> @@ -188,6 +188,13 @@ config PMIC_LP873X
>>  	The LP873X is a PMIC containing couple of LDOs and couple of SMPS.
>>  	This driver binds the pmic children.
>>  
>> +config PMIC_LP87565
>> +	bool "Enable driver for Texas Instruments LP87565 PMIC"
>> +	depends on DM_PMIC
>> +	---help---
>> +	The LP87565 is a PMIC containing a bunch of SMPS.
>> +	This driver binds the pmic children.
>> +
>>  config POWER_MC34VR500
>>  	bool "Enable driver for Freescale MC34VR500 PMIC"
>>  	---help---
>> diff --git a/drivers/power/pmic/Makefile b/drivers/power/pmic/Makefile
>> index f409e3a..f488799 100644
>> --- a/drivers/power/pmic/Makefile
>> +++ b/drivers/power/pmic/Makefile
>> @@ -21,6 +21,7 @@ obj-$(CONFIG_PMIC_TPS65090) += tps65090.o
>>  obj-$(CONFIG_PMIC_S5M8767) += s5m8767.o
>>  obj-$(CONFIG_$(SPL_)PMIC_PALMAS) += palmas.o
>>  obj-$(CONFIG_$(SPL_)PMIC_LP873X) += lp873x.o
>> +obj-$(CONFIG_$(SPL_)PMIC_LP87565) += lp87565.o
>>  
>>  obj-$(CONFIG_POWER_LTC3676) += pmic_ltc3676.o
>>  obj-$(CONFIG_POWER_MAX77696) += pmic_max77696.o
>> diff --git a/drivers/power/pmic/lp87565.c b/drivers/power/pmic/lp87565.c
>> new file mode 100644
>> index 0000000..9803bf9
>> --- /dev/null
>> +++ b/drivers/power/pmic/lp87565.c
>> @@ -0,0 +1,85 @@
>> +/*
>> + * (C) Copyright 2017 Texas Instruments Incorporated, <www.ti.com>
>> + * Keerthy <j-keerthy at ti.com>
>> + *
>> + * SPDX-License-Identifier:	GPL-2.0+
>> + */
>> +
>> +#include <common.h>
>> +#include <fdtdec.h>
>> +#include <errno.h>
>> +#include <dm.h>
>> +#include <i2c.h>
>> +#include <power/pmic.h>
>> +#include <power/regulator.h>
>> +#include <power/lp87565.h>
>> +#include <dm/device.h>
>> +
>> +DECLARE_GLOBAL_DATA_PTR;
>> +
>> +static const struct pmic_child_info pmic_children_info[] = {
>> +	{ .prefix = "buck", .driver = LP87565_BUCK_DRIVER },
>> +	{ },
>> +};
>> +
>> +static int lp87565_write(struct udevice *dev, uint reg, const uint8_t *buff,
>> +			  int len)
>> +{
>> +	if (dm_i2c_write(dev, reg, buff, len)) {
> 
> 
> I think you referred to the other file.. :)
> 
> dm_i2c_write() can be returned the other error number..
> I think the below code is better than now..I will modify the other files like below
> 
> ret = dm_i2c_read()
> if (ret)
> 	error();
> 
> return ret;

Jaehoon,

yes makes sense. So both dm_i2c_write and dm_i2c_read can return
different values. I will change like how you have suggested and post v3.

Thanks,
Keerthy

> 
>> +		error("write error to device: %p register: %#x!", dev, reg);
>> +		return -EIO;
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +static int lp87565_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
>> +{
>> +	if (dm_i2c_read(dev, reg, buff, len)) {
>> +		error("read error from device: %p register: %#x!", dev, reg);
>> +		return -EIO;
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +static int lp87565_bind(struct udevice *dev)
>> +{
>> +	ofnode regulators_node;
>> +	int children;
>> +
>> +	regulators_node = dev_read_subnode(dev, "regulators");
>> +	if (!ofnode_valid(regulators_node)) {
>> +		debug("%s: %s regulators subnode not found!", __func__,
>> +		      dev->name);
>> +		return -ENXIO;
>> +	}
>> +
>> +	debug("%s: '%s' - found regulators subnode\n", __func__, dev->name);
>> +
>> +	children = pmic_bind_children(dev, regulators_node, pmic_children_info);
>> +	if (!children)
>> +		printf("%s: %s - no child found\n", __func__, dev->name);
>> +
>> +	/* Always return success for this device */
>> +	return 0;
>> +}
>> +
>> +static struct dm_pmic_ops lp87565_ops = {
>> +	.read = lp87565_read,
>> +	.write = lp87565_write,
>> +};
>> +
>> +static const struct udevice_id lp87565_ids[] = {
>> +	{ .compatible = "ti,lp87565", .data = LP87565 },
>> +	{ .compatible = "ti,lp87565-q1", .data = LP87565_Q1 },
>> +	{ }
>> +};
>> +
>> +U_BOOT_DRIVER(pmic_lp87565) = {
>> +	.name = "lp87565_pmic",
>> +	.id = UCLASS_PMIC,
>> +	.of_match = lp87565_ids,
>> +	.bind = lp87565_bind,
>> +	.ops = &lp87565_ops,
>> +};
>> diff --git a/include/power/lp87565.h b/include/power/lp87565.h
>> new file mode 100644
>> index 0000000..5160f5d
>> --- /dev/null
>> +++ b/include/power/lp87565.h
>> @@ -0,0 +1,12 @@
>> +#define LP87565	0x0
>> +#define LP87565_Q1	0x1
>> +
>> +#define LP87565_BUCK_NUM		6
>> +
>> +/* Drivers name */
>> +#define LP87565_BUCK_DRIVER	"lp87565_buck"
>> +
>> +#define LP87565_BUCK_VOLT_MASK		0xFF
>> +#define LP87565_BUCK_VOLT_MAX_HEX	0xFF
>> +#define LP87565_BUCK_VOLT_MAX		3360000
>> +#define LP87565_BUCK_MODE_MASK		0x80
>>
>