[U-Boot] [PATCH v2 02/10] drivers: spi: consider command bytes when sending transfers

Álvaro Fernández Rojas noltari at gmail.com
Wed Jun 7 15:33:26 UTC 2017


Hi Jagan,

El 7/6/17 a las 9:30, Jagan Teki escribió:
> On Mon, May 22, 2017 at 11:51 PM, Álvaro Fernández Rojas
> <noltari at gmail.com> wrote:
>> Command bytes are part of the written bytes and they should be taken into
>> account when sending a spi transfer.
>>
>> Signed-off-by: Álvaro Fernández Rojas <noltari at gmail.com>
>> ---
>>  v2: Introduce changes requested by Simon Glass:
>>   - Always include command bytes when determining max write size.
>>
>>  drivers/mtd/spi/spi_flash.c | 2 +-
>>  include/spi.h               | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
>> index e44c10f..5b8cbc9 100644
>> --- a/drivers/mtd/spi/spi_flash.c
>> +++ b/drivers/mtd/spi/spi_flash.c
>> @@ -380,7 +380,7 @@ int spi_flash_cmd_write_ops(struct spi_flash *flash, u32 offset,
>>
>>                 if (spi->max_write_size)
>>                         chunk_len = min(chunk_len,
>> -                                       (size_t)spi->max_write_size);
>> +                                       spi->max_write_size - len);
> 
> This can be squashed with 01/10 with proper commit message?
I think it's better if we keep it as two patches, because they are different features...

> 
> thanks!
> 

Thanks.


More information about the U-Boot mailing list