[U-Boot] [PATCH 04/10] fdt: Add a check to do_fdt() for coverity

Simon Glass sjg at chromium.org
Wed Jun 7 16:28:41 UTC 2017


We know that fdt_getprop() does not return NULL when len is > 0 but
coverity does not. Add an extra check to keep it happy.

Signed-off-by: Simon Glass <sjg at chromium.org>
Reported-by: Coverity (CID: 163249)
Fixes: bc80295b (fdt: Add get commands to fdt)
---

 cmd/fdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/fdt.c b/cmd/fdt.c
index a21415dab4..3e889fc3bb 100644
--- a/cmd/fdt.c
+++ b/cmd/fdt.c
@@ -371,7 +371,7 @@ static int do_fdt(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 				/* no property value */
 				setenv(var, "");
 				return 0;
-			} else if (len > 0) {
+			} else if (nodep && len > 0) {
 				if (subcmd[0] == 'v') {
 					int ret;
 
-- 
2.13.0.506.g27d5fe0cd-goog



More information about the U-Boot mailing list