[U-Boot] [linux-sunxi] [PATCH v2] sun50i: a64: Add initial NanoPi A64 support

André Przywara andre.przywara at arm.com
Thu Jun 8 19:09:26 UTC 2017


On 08/06/17 18:43, Jagan Teki wrote:

Hi Jagan,

> From: Jagan Teki <jagan at amarulasolutions.com>
> 
> NanoPi A64 is a new board of high performance with low cost
> designed by FriendlyElec., using the Allwinner A64 SOC.
> 
> Nanopi A64 features
> - Allwinner A64, 64-bit Quad-core Cortex-A53 at 648MHz to 1.152GHz, DVFS
> - 1GB DDR3 RAM
> - MicroSD
> - Gigabit Ethernet (RTL8211E)
> - Wi-Fi 802.11b/g/n
> - IR receiver
> - Audio In/Out
> - Video In/Out
> - Serial Debug Port
> - microUSB 5V 2A DC power-supply
> 
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> Tested-by: Jagan Teki <jagan at amarulasolutions.com>
> ---
> Changes for v2:
> - Drop CONSOLE_MUX
> - Tested on board
> 
>  arch/arm/dts/Makefile                  |    1 +
>  arch/arm/dts/sun50i-a64-nanopi-a64.dts |   94 +
>  board/sunxi/MAINTAINERS                |    5 +
>  configs/nanopi_a64_defconfig           |   15 +
>  tools/libfdt.py                        |  992 ++++
>  tools/libfdt_wrap.c                    | 9628 ++++++++++++++++++++++++++++++++

Please don't merge those two files ;-)

>  6 files changed, 10735 insertions(+)
>  create mode 100644 arch/arm/dts/sun50i-a64-nanopi-a64.dts
>  create mode 100644 configs/nanopi_a64_defconfig
>  create mode 100644 tools/libfdt.py
>  create mode 100644 tools/libfdt_wrap.c
> 
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index ae55f78..427cbab 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -323,6 +323,7 @@ dtb-$(CONFIG_MACH_SUN50I_H5) += \
>  	sun50i-h5-orangepi-prime.dtb
>  dtb-$(CONFIG_MACH_SUN50I) += \
>  	sun50i-a64-bananapi-m64.dtb \
> +	sun50i-a64-nanopi-a64.dtb \
>  	sun50i-a64-pine64-plus.dtb \
>  	sun50i-a64-pine64.dtb
>  dtb-$(CONFIG_MACH_SUN9I) += \
> diff --git a/arch/arm/dts/sun50i-a64-nanopi-a64.dts b/arch/arm/dts/sun50i-a64-nanopi-a64.dts
> new file mode 100644
> index 0000000..17a571a
> --- /dev/null
> +++ b/arch/arm/dts/sun50i-a64-nanopi-a64.dts
> @@ -0,0 +1,94 @@
> +/*
> + * Copyright (C) 2017 Jagan Teki <jteki at openedev.com>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This library is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This library is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-a64.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> +	model = "FriendlyARM NanoPi A64";
> +	compatible = "friendlyarm,nanopi-a64", "allwinner,sun50i-a64";
> +
> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
> +	reg_vcc3v3: vcc3v3 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc3v3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +	};
> +};
> +
> +&i2c1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&i2c1_pins>;
> +	status = "okay";
> +};
> +
> +&i2c1_pins {
> +	bias-pull-up;
> +};
> +
> +&mmc0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mmc0_pins>;
> +	vmmc-supply = <&reg_vcc3v3>;
> +	cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
> +	cd-inverted;
> +	disable-wp;
> +	bus-width = <4>;
> +	status = "okay";
> +};
> +
> +&uart0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&uart0_pins_a>;
> +	status = "okay";
> +};

So according to the schematics the USB ports are powered by the 5V rail,
which is always enabled (as on the Pine64). So can you add the USB nodes
([eo]hci[01] and usbphy), each with status = "okay"?
That should make USB work out of the box.
Also since it has the WiFi/BT chip soldered, you could mark mmc1 and
UART1 as "okay".
Admittedly U-Boot doesn't care about all these bits, but it would allow
to use this one DT for both U-Boot and Linux. If you use $fdtcontroladdr
as the third argument to booti, you should be able to test whether this
very same DT works for Linux.
This saves you some work for the Linux submission as well ;-)

Otherwise this looks good to me.

Cheers,
Andre.

> diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS
> index 4fffe52..1de4a87 100644
> --- a/board/sunxi/MAINTAINERS
> +++ b/board/sunxi/MAINTAINERS
> @@ -262,6 +262,11 @@ M:	Jelle van der Waa <jelle at vdwaa.nl>
>  S:	Maintained
>  F:	configs/nanopi_neo_air_defconfig
>  
> +NANOPI-A64 BOARD
> +M:	Jagan Teki <jagan at amarulasolutions.com>
> +S:	Maintained
> +F:	configs/nanopi_a64_defconfig
> +
>  NINTENDO NES CLASSIC EDITION BOARD
>  M:	FUKAUMI Naoki <naobsd at gmail.com>
>  S:	Maintained
> diff --git a/configs/nanopi_a64_defconfig b/configs/nanopi_a64_defconfig
> new file mode 100644
> index 0000000..2f4ed11
> --- /dev/null
> +++ b/configs/nanopi_a64_defconfig
> @@ -0,0 +1,15 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_SUNXI=y
> +CONFIG_MACH_SUN50I=y
> +CONFIG_RESERVE_ALLWINNER_BOOT0_HEADER=y
> +CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-nanopi-a64"
> +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_SPL=y
> +# CONFIG_CMD_IMLS is not set
> +# CONFIG_CMD_FLASH is not set
> +# CONFIG_CMD_FPGA is not set
> +# CONFIG_SPL_DOS_PARTITION is not set
> +# CONFIG_SPL_ISO_PARTITION is not set
> +# CONFIG_SPL_EFI_PARTITION is not set
> +CONFIG_SUN8I_EMAC=y
> +CONFIG_USB_EHCI_HCD=y
> diff --git a/tools/libfdt.py b/tools/libfdt.py
> new file mode 100644
> index 0000000..93ff773
> --- /dev/null
> +++ b/tools/libfdt.py
> @@ -0,0 +1,992 @@
> +# This file was automatically generated by SWIG (http://www.swig.org).
> +# Version 3.0.8
> +#
> +# Do not make changes to this file unless you know what you are doing--modify

     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +# the SWIG interface file instead.




More information about the U-Boot mailing list