[U-Boot] [PATCH 1/2] arm: Add Kconfig symbols used for Linux asm compatibility

[Vikas MANOCHA]

Hi Tom,

> -----Original Message-----
> From: Tom Rini [mailto:trini at konsulko.com]
> Sent: Thursday, June 08, 2017 5:12 PM
> To: Vikas MANOCHA <vikas.manocha at st.com>
> Cc: Phil Edworthy <phil.edworthy at renesas.com>; Albert Aribaud <albert.u.boot at aribaud.net>; Kamil Lulko
> <kamil.lulko at gmail.com>; u-boot at lists.denx.de
> Subject: Re: [PATCH 1/2] arm: Add Kconfig symbols used for Linux asm compatibility
> 
> On Fri, Jun 09, 2017 at 12:07:40AM +0000, Vikas MANOCHA wrote:
> 
> > Hi Albert/Tom,
> >
> > > -----Original Message-----
> > > From: Phil Edworthy [mailto:phil.edworthy at renesas.com]
> > > Sent: Wednesday, May 31, 2017 11:33 PM
> > > To: Albert Aribaud <albert.u.boot at aribaud.net>
> > > Cc: Tom Rini <trini at konsulko.com>; Vikas MANOCHA
> > > <vikas.manocha at st.com>; Kamil Lulko <kamil.lulko at gmail.com>; u-
> > > boot at lists.denx.de; Phil Edworthy <phil.edworthy at renesas.com>
> > > Subject: [PATCH 1/2] arm: Add Kconfig symbols used for Linux asm
> > > compatibility
> > >
> > > Rather than change asm files that come from Linux, add the symbols
> > > to Kconfig. Since one of the symbols is for thumb2 builds, make CPU_V7M always select them.
> > >
> > > Signed-off-by: Phil Edworthy <phil.edworthy at renesas.com>
> > > ---
> > >  arch/arm/Kconfig      | 10 ++++++++++
> > >  arch/arm/lib/Makefile |  2 --
> > >  2 files changed, 10 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index
> > > 2a3a36e..2793651 100644
> > > --- a/arch/arm/Kconfigl
> > > +++ b/arch/arm/Kconfig
> > > @@ -19,6 +19,15 @@ config HAS_VBAR
> > >  config HAS_THUMB2
> > >  	bool
> > >
> > > +# Used for compatibility with asm files copied from the kernel
> > > +config ARM_ASM_UNIFIED
> > > +	bool
> > > +	default y
> >
> > Is every arm arch (arm720, arm926 etc) assembly code written for unified ?
> > Otherwise we might have run-time side effects.
> 
> I could be missing something, but this is only used by <asm/assembler.h> and in turn only by arch/arm/lib/*.S, where we already had
> been defining this.

Yes, you are right. I was under the impression that asm/assembler.h is being used by all arm archs everywhere like startup code, cache mgt etc.

Cheers,
Vikas

> 
> --
> Tom