[U-Boot] [PATCH v2] buildman: Translate binutils output to UTF-8

Simon Glass sjg at chromium.org
Fri Jun 9 12:27:30 UTC 2017


Hi Daniel,

On 7 June 2017 at 10:03, Daniel Schwierzeck
<daniel.schwierzeck at gmail.com> wrote:
>
>
> Am 07.06.2017 um 17:52 schrieb Simon Glass:
>> Hi Daniel,
>>
>> On 7 June 2017 at 06:19, Daniel Schwierzeck
>> <daniel.schwierzeck at gmail.com> wrote:
>>> binutils are using localized output. On systems with locales and special
>>> characters this leads to exceptions like this:
>>>
>>> Exception in thread Thread-7:
>>> Traceback (most recent call last):
>>>   File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
>>>     self.run()
>>>   File "/u-boot/tools/buildman/builderthread.py", line 475, in run
>>>     self.RunJob(job)
>>>   File "/u-boot/tools/buildman/builderthread.py", line 456, in RunJob
>>>     self._WriteResult(result, job.keep_outputs)
>>>   File "/u-boot/tools/buildman/builderthread.py", line 333, in _WriteResult
>>>     print >>fd, dump_result.stdout,
>>> UnicodeEncodeError: 'ascii' codec can't encode characters in position 75-76: ordinal not in range(128)
>>>
>>> Always encode the value of CommandResult::stdout to UTF-8 before
>>> writing it to stdout or a log file.
>>>
>>> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
>>>
>>> ---
>>>
>>> Changes in v2:
>>> - encode all occurences of CommandResult::stdout after spawning binutils to UTF-8
>>> - reworded commit message
>>>
>>>  tools/buildman/builderthread.py | 10 +++++-----
>>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>>
>>
>> I'm still seeing a rare failure, e.g.:
>>
>> https://travis-ci.org/sglass68/u-boot/jobs/240350621
>>
>> Any thoughts on that?
>>
>
> I'll look into it

Thanks. I believe the two new patches you sent supersede this one.

Regards,
Simon


More information about the U-Boot mailing list