[U-Boot] [PATCH 00/12] tegra: nyan-big: Support chainloading and add documentation

[Simon Glass]

Hi Stephen,

On 7 June 2017 at 09:41, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 06/07/2017 09:32 AM, Tom Warren wrote:
>>
>> Simon,
>>
>>> From: Simon Glass
>
> ...
>>>
>>> On 1 June 2017 at 07:52, Matthew Gorski <matt.gorski at gmail.com> wrote:
>>>>
>>>>
>>>> On Wed, May 31, 2017 at 2:28 PM, Matthew Gorski
>>>> <matt.gorski at gmail.com> wrote:
>>>>>
>>>>> On Mon, May 22, 2017 at 7:17 AM, Simon Glass <sjg at chromium.org>> wrote:
>>>>>>
>>>>>>
>>>>>> Every now and then someone wants to chain-load U-Boot on a Chromebook.
>>>>>> The procedure is not very complicated but there are some oddities.
>>>>>>
>>>>>> This series updates a few things with allow U-Boot to start on
>>>>>> nyan-big in this way and adds documentation on how to do it. This
>>>>>> provides a central place where the procedure on different devices can
>>>>>> be documented.
>
> ...
>>>>>
>>>>> Thank You for this Simon!  Very much appreciated!  I am going to give
>>>>> this a try later tonight and report back my personal results...
>
> ...
>
>>>> Confirmed! Chain-loading working on my nyan_big.  I appreciate this
>>>> very much Simon and all who contributed.
>>>
>>>
>>> I'd like to pull in this series. Are there any comments / reviews? If
>>> affects both
>>> tegra and rockchip.
>>
>> I'm fine with it - I assume you'll pull it in to one of your repos and
>> post a PR to get it into mainstream U-Boot?
>> I don't have the HW to test on (my nyan-big has been shelved), but trust
>> in Matthew's testing, and that Stephen's U-Boot test scripts will catch any
>> problems, so LGTM.

Thanks for looking at this.

>
>
> Yes, my testing should catch most issues with any patches, although there
> are still some coverage holes:
>
> 1) I don't test cold boot; U-boot is always loaded over USB RCM which may
> hide bugs specific to cold booting.

I tested cold bold on Nyan, but I use USB RCM also so don't normally
test cold boot.

>
> 2) I only test on a few HW platforms (beaver, dalmore, Jetson TK1,
> p2371-0000, Jetson TX1)

That's plenty :-)

>
> 3) Obviously I don't test the new features introduced by this patch;
> chain-loading.

It's OK I can rely on others for that so long as the changes are
acceptable to the normal boot case.

Regards,
Simon