[U-Boot] [PATCHv5 2/3] driver: mmc: update debug info

Simon Glass sjg at chromium.org
Fri Jun 9 12:27:41 UTC 2017


Hi Jorge,

On 29 May 2017 at 08:11, Jorge Ramirez-Ortiz
<jorge.ramirez-ortiz at linaro.org> wrote:
> This driver is used in another board; remove board information from
> the driver debug log.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz at linaro.org>
> ---
>  drivers/mmc/hi6220_dw_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

The patch looks OK but I barely understand how it relates to you
commit message. Could you redo the commit message to make it clearer?

BTW this driver should move to driver model (CONFIG_DM_MMC and
CONFIG_BLK). See for example exynos_dw_mmc.c

- Simon

>
> diff --git a/drivers/mmc/hi6220_dw_mmc.c b/drivers/mmc/hi6220_dw_mmc.c
> index fdaf1e4..d795198 100644
> --- a/drivers/mmc/hi6220_dw_mmc.c
> +++ b/drivers/mmc/hi6220_dw_mmc.c
> @@ -20,7 +20,7 @@
>
>  static int hi6220_dwmci_core_init(struct dwmci_host *host, int index)
>  {
> -       host->name = "HiKey DWMMC";
> +       host->name = "Hisilicon DWMMC";
>
>         host->dev_index = index;
>
> --
> 2.7.4
>


More information about the U-Boot mailing list