[U-Boot] [U-Boot, v4, 11/11] rockchip: dts: rk3399: control vbus of typec by fixed regulator

Dr. Philipp Tomsich philipp.tomsich at theobroma-systems.com
Fri Jun 9 12:41:22 UTC 2017


> On 08 Jun 2017, at 09:35, Meng Dongyang <daniel.meng at rock-chips.com> wrote:
> 
> Add fixed regulator for the port of typec0 and typec1 to control vbus
> instead of gpio.
> 
> Signed-off-by: Meng Dongyang <daniel.meng at rock-chips.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> ---
> 
> Changes in v4: None
> Changes in v3: None
> 
> Changes in v2:
> - New change, add fixed regulator for rk3399
> 
> arch/arm/dts/rk3399-evb.dts | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/dts/rk3399-evb.dts b/arch/arm/dts/rk3399-evb.dts
> index f5af75b..bff00c3 100644
> --- a/arch/arm/dts/rk3399-evb.dts
> +++ b/arch/arm/dts/rk3399-evb.dts
> @@ -60,6 +60,18 @@
> 		gpio = <&gpio4 25 GPIO_ACTIVE_HIGH>;
> 	};
> 
> +	vcc5v0_typec0: vcc5v0-typec0-en {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc5v0_typec0";
> +		gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>;
> +	};
> +
> +	vcc5v0_typec1: vcc5v0-typec1-en {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc5v0_typec1";
> +		gpio = <&gpio1 4 GPIO_ACTIVE_HIGH>;
> +	};
> +

Shouldn’t these written as RK_PA3 and RK_PA4 to remain consistent
with the Linux DTS?

> 	clkin_gmac: external-gmac-clock {
> 		compatible = "fixed-clock";
> 		clock-frequency = <125000000>;
> @@ -163,7 +175,7 @@
> };
> 
> &dwc3_typec0 {
> -	rockchip,vbus-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>;
> +	vbus-supply = <&vcc5v0_typec0>;
> 	status = "okay";
> };
> 
> @@ -176,7 +188,7 @@
> };
> 
> &dwc3_typec1 {
> -	rockchip,vbus-gpio = <&gpio1 4 GPIO_ACTIVE_HIGH>;
> +	vbus-supply = <&vcc5v0_typec1>;
> 	status = "okay";
> };
> 



More information about the U-Boot mailing list