[U-Boot] [PATCH] rockchip: video: fix taking the VOP device out of standby

Philipp Tomsich philipp.tomsich at theobroma-systems.com
Fri Jun 9 16:24:37 UTC 2017


The VOP uses regular registers, so use setbits_le32/clrbits_le32
instead of rk_setbits/rk_clrbits.

Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
---

 drivers/video/rockchip/rk3288_vop.c | 2 +-
 drivers/video/rockchip/rk_vop.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/rockchip/rk3288_vop.c b/drivers/video/rockchip/rk3288_vop.c
index 758ebaf..3a5740a 100644
--- a/drivers/video/rockchip/rk3288_vop.c
+++ b/drivers/video/rockchip/rk3288_vop.c
@@ -75,7 +75,7 @@ static int rk_vop_remove(struct udevice *dev)
 	struct rk_vop_priv *priv = dev_get_priv(dev);
         struct rk3288_vop *regs = priv->regs;
 
-	rk_setreg(&regs->sys_ctrl, V_STANDBY_EN(1));
+	setbits_le32(&regs->sys_ctrl, V_STANDBY_EN(1));
 
 	/* wait frame complete (60Hz) to enter standby */
 	mdelay(17);
diff --git a/drivers/video/rockchip/rk_vop.c b/drivers/video/rockchip/rk_vop.c
index bac4def..c979049 100644
--- a/drivers/video/rockchip/rk_vop.c
+++ b/drivers/video/rockchip/rk_vop.c
@@ -106,7 +106,7 @@ static void rkvop_enable_output(struct udevice *dev, enum vop_modes mode)
 	struct rk3288_vop *regs = priv->regs;
 
 	/* remove from standby */
-	rk_clrreg(&regs->sys_ctrl, V_STANDBY_EN(1));
+	clrbits_le32(&regs->sys_ctrl, V_STANDBY_EN(1));
 
 	switch (mode) {
 	case VOP_MODE_HDMI:
-- 
2.1.4



More information about the U-Boot mailing list