[U-Boot] [PATCH] common/fb_mmc.c: Fix warnings about casts

Sam Protsenko semen.protsenko at linaro.org
Mon Jun 12 11:28:07 UTC 2017


On 10 June 2017 at 16:15, Tom Rini <trini at konsulko.com> wrote:
> When building the flash zImage code on aarch64 we see warnings about
> pointer size casts.  Use uintptr_t instead to correct these.
>
> Cc: Sam Protsenko <semen.protsenko at linaro.org>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  common/fb_mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/fb_mmc.c b/common/fb_mmc.c
> index 2113b6c37239..f085c1b8151c 100644
> --- a/common/fb_mmc.c
> +++ b/common/fb_mmc.c
> @@ -162,7 +162,7 @@ static int fb_mmc_update_zimage(struct blk_desc *dev_desc,
>                                 void *download_buffer,
>                                 unsigned int download_bytes)
>  {
> -       u32 hdr_addr;                           /* boot image header address */
> +       uintptr_t hdr_addr;                     /* boot image header address */
>         struct andr_img_hdr *hdr;               /* boot image header */
>         lbaint_t hdr_sectors;                   /* boot image header sectors */
>         u8 *ramdisk_buffer;
> @@ -185,7 +185,7 @@ static int fb_mmc_update_zimage(struct blk_desc *dev_desc,
>         }
>
>         /* Put boot image header in fastboot buffer after downloaded zImage */
> -       hdr_addr = (u32)download_buffer + ALIGN(download_bytes, PAGE_SIZE);
> +       hdr_addr = (uintptr_t)download_buffer + ALIGN(download_bytes, PAGE_SIZE);
>         hdr = (struct andr_img_hdr *)hdr_addr;
>
>         /* Read boot image header */
> --
> 1.9.1
>

Reviewed-By: Sam Protsenko <semen.protsenko at linaro.org>

Thanks, Tom, I forgot to check the build on ARMv8 boards.


More information about the U-Boot mailing list