[U-Boot] [PATCH 2/3] regulator: lp873x: Fix the return value of ldo_get_enable function

Simon Glass sjg at chromium.org
Mon Jun 12 23:51:06 UTC 2017


On 10 June 2017 at 23:01, Keerthy <j-keerthy at ti.com> wrote:
> The function wrongly returned an integer while it is supposed to
> return boolean. Fix that.
>
> Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support")
> Signed-off-by: Keerthy <j-keerthy at ti.com>
> ---
>  drivers/power/regulator/lp873x_regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>

I think in fact we should return int from this method in struct
dm_regulator_ops. I don't really like not being able to return an
error.

So bonus points if you can change that :-)


More information about the U-Boot mailing list