[U-Boot] [PATCH 0/7] rockchip: Split sdram common function into sdram_common.c

Dr. Philipp Tomsich philipp.tomsich at theobroma-systems.com
Tue Jun 13 10:12:21 UTC 2017


I just realised this myself after pulling it into my tree to take a closer look
and possibly give it a spin… my euphoria was gone rather quickly.

Since I have SPL set up for the 3368 and have all the "necessary notes”
(which usually leads into the realisation that there’s necessary and sufficient
are two very distinct concepts) on my desk to write the DRAM init code for it,
I might as well sit down and continue down this path.

We have quite a few RK3368-uQ7 modules in the lab—so having mainline
U-Boot support is becoming a priority.

> On 13 Jun 2017, at 12:04, Heiko Stübner <heiko at sntech.de> wrote:
> 
> Am Dienstag, 13. Juni 2017, 11:31:53 CEST schrieb Dr. Philipp Tomsich:
>> Kever,
>> 
>> thanks a lot! I had just started to work on RK3368 SPL code and the DDR
>> controller would have been next on the list…
>> You saved me quite a bit of work there.
> 
> Although the sdram drivers for rk3328 and rk3368 only seem to provide the
> non-spl portions for now.
> 
> Kever, is there a rough time estimate for spl support for these socs?
> (Got a rk3328-rock64 sample yesterday, so would be interested on getting
> a mainline u-boot to run on it)
> 
> 
> Thanks
> Heiko
> 
>> 
>> Regards,
>> Philipp.
>> 
>>> On 13 Jun 2017, at 11:29, Kever Yang <kever.yang at rock-chips.com> wrote:
>>> 
>>> 
>>> Some function like the dram capability decode and dram_init() are
>>> the same for all Rockchip SoCs, maybe alaso cap detect function later,
>>> add sdram_common.c for all SoC driver.
>>> 
>>> Kever Yang (7):
>>> rockchip: add sdram_common for common functions
>>> rockchip: use common sdram function
>>> rockchip: rk3328: add sdram driver in U-Boot
>>> rockchip: rk3368: add sdram driver for U-Boot
>>> rockchip: dts: rk3328: add dmc node
>>> rockchip: dts: rk3368: add dmc node
>>> rockchip: correct the bank0 ram size
>>> 
>>> arch/arm/dts/rk3328.dtsi                          |  7 ++
>>> arch/arm/dts/rk3368.dtsi                          |  7 ++
>>> arch/arm/include/asm/arch-rockchip/ddr_rk3288.h   | 48 -----------
>>> arch/arm/include/asm/arch-rockchip/grf_rk3368.h   |  4 +-
>>> arch/arm/include/asm/arch-rockchip/sdram_common.h | 58 ++++++++++++++
>>> arch/arm/mach-rockchip/Makefile                   |  3 +
>>> arch/arm/mach-rockchip/rk3188-board.c             | 22 -----
>>> arch/arm/mach-rockchip/rk3188/sdram_rk3188.c      | 61 +++-----------
>>> arch/arm/mach-rockchip/rk3288-board.c             | 22 -----
>>> arch/arm/mach-rockchip/rk3288/sdram_rk3288.c      | 74 +++++------------
>>> arch/arm/mach-rockchip/rk3328/Makefile            |  1 +
>>> arch/arm/mach-rockchip/rk3328/sdram_rk3328.c      | 66 +++++++++++++++
>>> arch/arm/mach-rockchip/rk3368/Makefile            |  1 +
>>> arch/arm/mach-rockchip/rk3368/sdram_rk3368.c      | 66 +++++++++++++++
>>> arch/arm/mach-rockchip/rk3399/sdram_rk3399.c      | 97
>>> ++--------------------- arch/arm/mach-rockchip/sdram_common.c            
>>> | 71 +++++++++++++++++ board/rockchip/evb_rk3328/evb-rk3328.c           
>>> |  8 +-
>>> board/rockchip/evb_rk3399/evb-rk3399.c            | 24 +-----
>>> board/rockchip/sheep_rk3368/sheep_rk3368.c        |  9 +--
>>> board/theobroma-systems/puma_rk3399/puma-rk3399.c | 24 +-----
>>> 20 files changed, 324 insertions(+), 349 deletions(-)
>>> create mode 100644 arch/arm/include/asm/arch-rockchip/sdram_common.h
>>> create mode 100644 arch/arm/mach-rockchip/rk3328/sdram_rk3328.c
>>> create mode 100644 arch/arm/mach-rockchip/rk3368/sdram_rk3368.c
>>> create mode 100644 arch/arm/mach-rockchip/sdram_common.c
> 
> 



More information about the U-Boot mailing list