[U-Boot] [PATCH v6 01/11] reset: add reset_request()

Patrice CHOTARD patrice.chotard at st.com
Wed Jun 14 07:06:06 UTC 2017


Hi Marek

On 06/13/2017 10:45 AM, Marek Vasut wrote:
> On 06/12/2017 09:24 AM, Patrice CHOTARD wrote:
>> Hi Tom
>>
>> I think this series is mature enough to be merged.
> 
> I think there's still some discussion with Simon going on ?
> Also, please don't top-post.

Yes, i saw Simon's request after sending this email.
I will submit a v7 of this series

Patrice


> 
>> Thanks
>>
>> Patrice
>>
>>
>> On 06/05/2017 11:42 AM, patrice.chotard at st.com wrote:
>>> From: Patrice Chotard <patrice.chotard at st.com>
>>>
>>> This is needed in error path to assert previously deasserted
>>> reset by using a saved reset_ctl reference.
>>>
>>> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>> ---
>>> v6:	_ none
>>> v5:	_ none
>>> v4:	_ none
>>> v3:	_ none
>>> v2:	_ none
>>>
>>>    drivers/reset/reset-uclass.c | 9 +++++++++
>>>    include/reset.h              | 9 +++++++++
>>>    2 files changed, 18 insertions(+)
>>>
>>> diff --git a/drivers/reset/reset-uclass.c b/drivers/reset/reset-uclass.c
>>> index de3695f..4fd82b9 100644
>>> --- a/drivers/reset/reset-uclass.c
>>> +++ b/drivers/reset/reset-uclass.c
>>> @@ -97,6 +97,15 @@ int reset_get_by_name(struct udevice *dev, const char *name,
>>>    	return reset_get_by_index(dev, index, reset_ctl);
>>>    }
>>>    
>>> +int reset_request(struct reset_ctl *reset_ctl)
>>> +{
>>> +	struct reset_ops *ops = reset_dev_ops(reset_ctl->dev);
>>> +
>>> +	debug("%s(reset_ctl=%p)\n", __func__, reset_ctl);
>>> +
>>> +	return ops->request(reset_ctl);
>>> +}
>>> +
>>>    int reset_free(struct reset_ctl *reset_ctl)
>>>    {
>>>    	struct reset_ops *ops = reset_dev_ops(reset_ctl->dev);
>>> diff --git a/include/reset.h b/include/reset.h
>>> index f45fcf8..4f2e35f 100644
>>> --- a/include/reset.h
>>> +++ b/include/reset.h
>>> @@ -100,6 +100,15 @@ int reset_get_by_name(struct udevice *dev, const char *name,
>>>    		      struct reset_ctl *reset_ctl);
>>>    
>>>    /**
>>> + * reset_request - Request a reset signal.
>>> + *
>>> + * @reset_ctl:	A reset control struct.
>>> + *
>>> + * @return 0 if OK, or a negative error code.
>>> + */
>>> +int reset_request(struct reset_ctl *reset_ctl);
>>> +
>>> +/**
>>>     * reset_free - Free a previously requested reset signal.
>>>     *
>>>     * @reset_ctl:	A reset control struct that was previously successfully
> 
> 


More information about the U-Boot mailing list